| Age | Commit message (Collapse) | Author |
|
Add `is_valid_order`, which checks that a submitted order is a permutation of
the file's samples (catching missing, extra and duplicated samples), with tests.
Co-authored-by: pi coding agent <pi@pi.dev>
|
|
Cover alphabetical fallback, retaining an existing population order, appending
missing samples sorted, ignoring existing samples not in the file, and the empty
case.
Co-authored-by: pi coding agent <pi@pi.dev>
|
|
Add a fixture and QC test showing that a marker name repeated on the same
chromosome is an error, while the same name may appear on different
chromosomes.
Co-authored-by: pi coding agent <pi@pi.dev>
|
|
Add fixtures and tests for negative and non-numeric cM/Mb values in both
orientations, confirm non-negative integers/floats are accepted, and cover
job-error extraction for invalid positions.
Co-authored-by: pi coding agent <pi@pi.dev>
|
|
Update fixtures to cover empty/missing-value headings (header row, transposed
row labels, marker headings), marker values, metadata values and empty sample
values. Add Stage 01 tests for each case and update the job-error extraction
expectations.
Co-authored-by: pi coding agent <pi@pi.dev>
|
|
Add tests for `job_errors.errors_from_job` using the sample genotype files:
collector column-mismatch errors, clean collector output, QC unknown/empty
values (untransposed and transposed), non-JSON output, and message-only errors.
Co-authored-by: pi coding agent <pi@pi.dev>
|
|
Small untransposed/transposed genotype files (clean, with collector errors, with
value errors, and with ragged rows) plus one exercising comments and dot-geno
directives. Intended for manual checks now and automated tests later.
Co-authored-by: pi coding agent <pi@pi.dev>
|
|
Add normalisation tests (comments/directives dropped, transposed files
untransposed, ragged/empty rejected) and update the QC sorting tests for the
chromosome -> Mb -> cM placeholder order. Drop the obsolete transposed QC test
since QC now runs on the canonical file.
Co-authored-by: pi coding agent <pi@pi.dev>
|
|
Cover comments before and after the header/markers row (untransposed and
transposed), the chunk-merge behaviour, and single- vs multi-processed
equivalence when a mid-file comment lands in a later chunk.
Co-authored-by: pi coding agent <pi@pi.dev>
|
|
- Store the genotype file path and collector config in the collector job
metadata so later stages can re-read the file.
- Seed `dot_geno_fields.unk` into the Stage 02 missing-value symbols default.
- Add `uploader.genotypes.qc` with value checks (empty and unknown symbols)
and a placeholder marker-ordering helper (chromosome, cM, Mb) that warns.
- Add the `uploader.scripts.genotypes.qc` worker that reads the collector job,
runs the checks and exits non-zero when errors are found.
- On Stage 02 save, schedule the QC job and record its id for idempotency.
|
|
Move `parse_missing_values_symbols` from the genotypes views into
`r_qtl.utils` and use it in the genotypes Stage 01 collector config and the
phenotypes individual-file uploads, replacing their divergent inline splits
with the more robust whitespace/comma parsing. Move the tests to
`tests/r_qtl/test_utils.py`.
|
|
Add tests for splitting a whitespace- and/or comma-separated symbol list into
unique, non-empty symbols.
|
|
|
|
Add tests for validating a collector job (type, completion, dataset
ownership) and parsing the FileStats from its recorded stdout.
|
|
Move `uploader/scripts/genotypes/types.py` to `uploader/genotypes/types.py` so
application code can use `FileStats` and friends without importing from
`uploader.scripts`. Update the collector script and tests to the new location.
|
|
Add tests for cleaning comment lines (strip the comment character and
surrounding whitespace), honouring a configured comment character, exposing the
description on FileStats, and preserving comment order when merging chunks.
|
|
|
|
Add tests for translating the collector config into the collector CLI's
arguments (log level, file metadata, separator/comment/NA strings and the
transposed flag), with the file path as the final argument.
|
|
Add tests for mapping the upload form's metadata fields to the statistics
collector's config keys, including collector defaults, the transposed checkbox
and normalisation of the missing-value strings.
|
|
Add unit tests for a generic `resolve_uploaded_file` in the uploader.files
package: direct multipart and resumable uploads (returning both the path and
the original name), hashed vs unhashed saving, and the error cases (missing
file, malformed resumable data, wrong field).
|
|
The `scripts` package now lives under `uploader`, so update every reference
from `scripts.<...>` to `uploader.scripts.<...>`: Python imports, `-m` command
module strings, logging module names, test imports, CLI/gunicorn entry points,
lint/guix paths and the WIP documentation.
Note: the untracked `run-dev-flask.sh` and `run-dev-gunicorn.sh` helper scripts
still need their entry-point module updated manually.
|
|
Add pytest unit tests asserting that `file_stats_multiprocessing` produces
the same statistics as `file_stats_singlethread` for untransposed and
transposed files across a range of chunk sizes, that line errors keep their
order, and that `_read_chunks` groups lines correctly including the
partial final chunk and empty input.
|
|
Add pytest unit tests for `_merge_chunk_stats` and
`_merge_all_chunk_stats`, covering counter summation, symbol union,
error ordering, dot-geno field overriding, and the untransposed
(concatenate) and transposed (last markers line wins) marker semantics.
|
|
Add pytest unit tests for the extracted `_accumulate` helper and for
`file_stats_singlethread`, covering line-type counting, collection of
genotype symbols/markers/dot-geno fields, transposed files, and the
ordering of header validation errors before per-line errors.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Markup can, and will change as improvements are made, but the error
messages will not change that often, plus that is what we want to
actually test for, not the markup.
|
|
|
|
R/qtl2 bundles can contain more than one file, of the same type. When
errors are encountered in any of the files, we need to be able to
inform the user which file it is, in addition to the line and column
number.
|
|
|
|
|
|
|
|
|
|
|
|
|