about summary refs log tree commit diff
path: root/tests/uploader/genotypes
AgeCommit message (Collapse)Author
6 daysValidate submitted sample ordersFrederick Muriuki Muriithi
Add `is_valid_order`, which checks that a submitted order is a permutation of the file's samples (catching missing, extra and duplicated samples), with tests. Co-authored-by: pi coding agent <pi@pi.dev>
6 daysTest: cover genotype sample order proposalFrederick Muriuki Muriithi
Cover alphabetical fallback, retaining an existing population order, appending missing samples sorted, ignoring existing samples not in the file, and the empty case. Co-authored-by: pi coding agent <pi@pi.dev>
6 daysTest: cover duplicate marker names within a chromosomeFrederick Muriuki Muriithi
Add a fixture and QC test showing that a marker name repeated on the same chromosome is an error, while the same name may appear on different chromosomes. Co-authored-by: pi coding agent <pi@pi.dev>
6 daysTest: cover non-negative numeric position validationFrederick Muriuki Muriithi
Add fixtures and tests for negative and non-numeric cM/Mb values in both orientations, confirm non-negative integers/floats are accepted, and cover job-error extraction for invalid positions. Co-authored-by: pi coding agent <pi@pi.dev>
6 daysTest: cover early validation of headings and data valuesFrederick Muriuki Muriithi
Update fixtures to cover empty/missing-value headings (header row, transposed row labels, marker headings), marker values, metadata values and empty sample values. Add Stage 01 tests for each case and update the job-error extraction expectations. Co-authored-by: pi coding agent <pi@pi.dev>
6 daysTest: cover genotype job error extraction from fixturesFrederick Muriuki Muriithi
Add tests for `job_errors.errors_from_job` using the sample genotype files: collector column-mismatch errors, clean collector output, QC unknown/empty values (untransposed and transposed), non-JSON output, and message-only errors. Co-authored-by: pi coding agent <pi@pi.dev>
6 daysAdd sample genotype files for upload testingFrederick Muriuki Muriithi
Small untransposed/transposed genotype files (clean, with collector errors, with value errors, and with ragged rows) plus one exercising comments and dot-geno directives. Intended for manual checks now and automated tests later. Co-authored-by: pi coding agent <pi@pi.dev>
7 daysTest: cover genotype normalisation and marker sortingFrederick Muriuki Muriithi
Add normalisation tests (comments/directives dropped, transposed files untransposed, ragged/empty rejected) and update the QC sorting tests for the chromosome -> Mb -> cM placeholder order. Drop the obsolete transposed QC test since QC now runs on the canonical file. Co-authored-by: pi coding agent <pi@pi.dev>
13 daysAdd Stage 03 genotype value QC and schedule it from Stage 02pi coding agent
- Store the genotype file path and collector config in the collector job metadata so later stages can re-read the file. - Seed `dot_geno_fields.unk` into the Stage 02 missing-value symbols default. - Add `uploader.genotypes.qc` with value checks (empty and unknown symbols) and a placeholder marker-ordering helper (chromosome, cM, Mb) that warns. - Add the `uploader.scripts.genotypes.qc` worker that reads the collector job, runs the checks and exits non-zero when errors are found. - On Stage 02 save, schedule the QC job and record its id for idempotency.
13 daysUnify missing-value symbol parsing in r_qtl.utilspi coding agent
Move `parse_missing_values_symbols` from the genotypes views into `r_qtl.utils` and use it in the genotypes Stage 01 collector config and the phenotypes individual-file uploads, replacing their divergent inline splits with the more robust whitespace/comma parsing. Move the tests to `tests/r_qtl/test_utils.py`.
13 daysTest: cover parsing missing-value symbolspi coding agent
Add tests for splitting a whitespace- and/or comma-separated symbol list into unique, non-empty symbols.
13 daysMove tests to appropriate test package.Frederick Muriuki Muriithi