diff options
| author | Frederick Muriuki Muriithi | 2026-01-23 17:27:20 -0600 |
|---|---|---|
| committer | Frederick Muriuki Muriithi | 2026-01-23 17:27:20 -0600 |
| commit | f8bcce2b4cb64a69f35b6bdce7fe085613ff5707 (patch) | |
| tree | fd41219345527e0deff761932ff368e96881a952 | |
| parent | 7718177c7d8d130d79f97fe8b5d963295391783d (diff) | |
| download | gn-uploader-f8bcce2b4cb64a69f35b6bdce7fe085613ff5707.tar.gz | |
DataTables: Only set the "data" and "columns" options if not empty.
To prevent the utility function from breaking the way DataTables works when you provide an already populated table, only set the data and columns options if the user actually provides values for them.
| -rw-r--r-- | uploader/static/js/datatables.js | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/uploader/static/js/datatables.js b/uploader/static/js/datatables.js index 82fd696..e111c11 100644 --- a/uploader/static/js/datatables.js +++ b/uploader/static/js/datatables.js @@ -35,8 +35,6 @@ var buildDataTable = (tableId, data = [], columns = [], userSettings = {}) => { lengthMenu: "", info: "" }, - data: data, - columns: columns, drawCallback: (settings) => { $(this[0]).find("tbody tr").each((idx, row) => { var arow = $(row); @@ -53,7 +51,9 @@ var buildDataTable = (tableId, data = [], columns = [], userSettings = {}) => { } var theDataTable = $(tableId).DataTable({ ...defaultSettings, - ...userSettings + ...userSettings, + ...(data.length == 0 ? {} : {data: data}), + ...(columns.length == 0 ? {} : {columns: columns}) }); theDataTable.on("select", (event, datatable, type, cell, originalEvent) => { datatable.rows({selected: true}).nodes().each((node, index) => { |
