about summary refs log tree commit diff
path: root/gn3/computations
AgeCommit message (Collapse)Author
2026-10-12gemma: remove the broken /api/gemma endpoints and their unreachable codePjotr
gn3/computations/gemma.py's generate_gemma_cmd always appended "-gk" to every composed command, including its gwa-compute/k-gwa-compute endpoints that also set -lmm. Confirmed by actually running the composed command against real gemma-wrapper/GEMMA: real GEMMA rejects that combination outright ("only one of -gk ... -lmm ... options is allowed"), so none of these endpoints could ever produce output. tests/integration/test_gemma.py was entirely @unittest.skip, so this was never caught. Checked that GeneNetwork2 never called these endpoints over HTTP (no reference to api/gemma, k-compute, gwa-compute or k-gwa-compute anywhere in its codebase) -- it runs gemma-wrapper itself directly (wqflask/marker_regression/gemma_mapping.py), via its own GEMMA_WRAPPER_COMMAND and os.system() calls, never through GN3's API. So these endpoints had no real caller on either side. Removed: - gn3/api/gemma.py and its blueprint registration in gn3/app.py. - generate_gemma_cmd and generate_pheno_txt_file from gn3/computations/gemma.py (gn3/api/gemma.py was their only caller). generate_hash_of_string stays: GeneNetwork2 imports it directly (gemma_mapping.py, export_traits.py, views.py), and gn3/computations/rqtl.py uses it too. - compose_gemma_cmd from gn3/commands.py (generate_gemma_cmd was its only caller), and the now-unused `List` import that went with it. - tests/integration/test_gemma.py (tested only the removed blueprint). - The generate_gemma_cmd/generate_pheno_txt_file tests from tests/unit/computations/test_gemma.py and the compose_gemma_cmd tests from tests/unit/test_commands.py; generate_hash_of_string's and compose_rqtl_cmd's own tests stay. - CACHEDIR and GEMMA_WRAPPER_CMD from gn3/settings.json: both were read only by the removed gn3/api/gemma.py. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
2026-10-06Fix PCA logiczsloan
Previously it was using the correlation table as input instead of the actual traits, so the results were completely wrong There was also a missing transpose from the GN2 version
2025-10-22typing: Fix type errors.Frederick Muriuki Muriithi
2025-10-22Fetch configs from app setting and pass them downFrederick Muriuki Muriithi
Fix the code to avoid using global variables holding configuration variables to avoid the failures caused by action-at-a-distance effects due to change of a value elsewhere. This way, all code consistently receives the same configuration values passed on from callers. We pass on the following configuration settings: * TMPDIR * SQL_URI * TEXTDIR
2025-08-06Use default `quotechar=None`.Frederick Muriuki Muriithi
2025-04-14Include effect mean/SE for 4-way crosses in R/qtl resultszsloan
2025-04-08BUG: Provide a tuple, of tuple of floatsFrederick Muriuki Muriithi
The downstream functions seem to expect a tuple of tuples of floats.
2025-04-08Use correct key.Frederick Muriuki Muriithi
2025-04-08Indent code properly.Frederick Muriuki Muriithi
2025-03-27feat: Check for founder and covar file in rqtl2 metadata.Alexander_Kabui
2025-03-07refactor function to process scan1 results.Alexander_Kabui
2025-02-28Eliminate carriage-return and newline characters.Frederick Muriuki Muriithi
2025-02-28Print out the stack trace to help debug failures.Frederick Muriuki Muriithi
2025-02-28Fix issues caught by mypy.Frederick Muriuki Muriithi
2025-02-28Fix linting errors.Frederick Muriuki Muriithi
2025-02-26feat: Add utility function for reading files and improve loggingAlexander_Kabui
* Add `read_file(file_path)` utility function to streamline file reading. * Updated `run_process()` to return log contents instead of just the log file path.
2025-02-25fix: handle extra columns in permutations CSV reader to prevent unpacking error.Alexander_Kabui
2025-02-24Fetch rscript from os env if it isn't set in the app's config.Munyoki Kilyungi
Signed-off-by: Munyoki Kilyungi <me@bonfacemunyoki.com>
2025-02-20refactor: Skip permutation test when NO_OF_PERMUTATION less than 0.Alexander_Kabui
2025-02-19fix: Read and parse correct permutation file from R/qtl2.Alexander_Kabui
2025-02-19fix: Read and parse correct permutation file from R/qtl1Alexander_Kabui
2025-02-07refactor: Add rqtl2 default method and update unittests.Alexander_Kabui
2025-02-07feat: Add the qtl to method to be used.Alexander_Kabui
2025-02-07fix: fix for fetching significance results.Alexander_Kabui
2025-02-06feat: Include the physical map position in results.Alexander_Kabui
2025-02-06refactor: Rename pheno_map to physical_map .Alexander_Kabui
2025-02-06mypy fixes.Alexander_Kabui
2025-02-06refactor process qtl2 results function to include output reading.Alexander_Kabui
2025-02-06feat: Add function to process qtl2 output results.Alexander_Kabui
2025-02-06feat: Add function to process qtl scan results.Alexander_Kabui
2025-02-06feat: Add function to process permutation results.Alexander_Kabui
2025-02-06feat: Add function to fetch significance results.Alexander_Kabui
2025-02-06Refactor: return the relative file to the workspace directory.Alexander_Kabui
2025-02-06Refactor workspace directory creation to use pathlib's mkdir method.Alexander_Kabui
2025-02-06refactor: Minor cleanup.Alexander_Kabui
2025-02-06refactor: Refactor run_process function.Alexander_Kabui
2025-02-06refactor: Add file_path to output only if it is created.Alexander_Kabui
2025-02-06refactor: Check if data before attempting write operation.Alexander_Kabui
2025-02-06refactor: return code for Calledprocesserror response.Alexander_Kabui
2025-02-06feat: Add module docstring for rqtl2 computations.Alexander_Kabui
2025-02-06refactor: remove unused imports.Alexander_Kabui
2025-02-06feat: Add function to write input data to a json file.Alexander_Kabui
2025-02-06feat: Add function to prepare files and workspace directory for computation.Alexander_Kabui
2025-02-06feat: Add utility function to create a file if it does not exist.Alexander_Kabui
2025-02-06feat: Add function to compose an rqtl2 run command.Alexander_Kabui
2025-02-06feat: Add function to validate list of keys in object.Alexander_Kabui
2025-02-06feat: Add function to generate rqtl2 data files.Alexander_Kabui
2025-02-06feat: Add method to write list of data to csv file.Alexander_Kabui
2025-02-06feat: Add computational module for rqtl2.Alexander_Kabui
2025-01-13mypy fixes.Alexander_Kabui