aboutsummaryrefslogtreecommitdiff
path: root/uploader/population
diff options
context:
space:
mode:
Diffstat (limited to 'uploader/population')
-rw-r--r--uploader/population/models.py2
-rw-r--r--uploader/population/views.py26
2 files changed, 22 insertions, 6 deletions
diff --git a/uploader/population/models.py b/uploader/population/models.py
index 6dcd85e..d78a821 100644
--- a/uploader/population/models.py
+++ b/uploader/population/models.py
@@ -61,7 +61,7 @@ def save_population(cursor: mdb.cursors.Cursor, population_details: dict) -> dic
**population_details,
"FamilyOrder": _families.get(
population_details["Family"],
- max(_families.values())+1)
+ max((0,) + tuple(_families.values()))+1)
}
cursor.execute(
"INSERT INTO InbredSet("
diff --git a/uploader/population/views.py b/uploader/population/views.py
index 4f985f5..270dd5f 100644
--- a/uploader/population/views.py
+++ b/uploader/population/views.py
@@ -2,6 +2,7 @@
import json
import base64
+from markupsafe import escape
from MySQLdb.cursors import DictCursor
from gn_libs.mysqldb import database_connection
from flask import (flash,
@@ -19,11 +20,9 @@ from uploader.genotypes.views import genotypesbp
from uploader.datautils import enumerate_sequence
from uploader.phenotypes.views import phenotypesbp
from uploader.expression_data.views import exprdatabp
+from uploader.species.models import all_species, species_by_id
from uploader.monadic_requests import make_either_error_handler
from uploader.input_validation import is_valid_representative_name
-from uploader.species.models import (all_species,
- species_by_id,
- order_species_by_family)
from .models import (save_population,
population_families,
@@ -48,7 +47,15 @@ def index():
if not bool(request.args.get("species_id")):
return render_template(
"populations/index.html",
- species=order_species_by_family(all_species(conn)))
+ species=all_species(conn),
+ activelink="populations")
+
+ species_id = request.args.get("species_id")
+ if species_id == "CREATE-SPECIES":
+ return redirect(url_for(
+ "species.create_species",
+ return_to="species.populations.list_species_populations"))
+
species = species_by_id(conn, request.args.get("species_id"))
if not bool(species):
flash("Invalid species identifier provided!", "alert-danger")
@@ -101,6 +108,7 @@ def create_population(species_id: int):
{"id": "2", "value": "GEMMA"},
{"id": "3", "value": "R/qtl"},
{"id": "4", "value": "GEMMA, PLINK"}),
+ return_to=(request.args.get("return_to") or ""),
activelink="create-population",
**error_values)
@@ -151,7 +159,15 @@ def create_population(species_id: int):
})
def __flash_success__(_success):
- flash("Successfully created resource.", "alert-success")
+ flash("Successfully created population "
+ f"{escape(new_population['FullName'])}.",
+ "alert-success")
+ return_to = request.form.get("return_to") or ""
+ if return_to:
+ return redirect(url_for(
+ return_to,
+ species_id=species["SpeciesId"],
+ population_id=new_population["InbredSetId"]))
return redirect(url_for(
"species.populations.view_population",
species_id=species["SpeciesId"],