| Age | Commit message (Collapse) | Author |
|
gn3/computations/gemma.py's generate_gemma_cmd always appended "-gk"
to every composed command, including its gwa-compute/k-gwa-compute
endpoints that also set -lmm. Confirmed by actually running the
composed command against real gemma-wrapper/GEMMA: real GEMMA rejects
that combination outright ("only one of -gk ... -lmm ... options is
allowed"), so none of these endpoints could ever produce output.
tests/integration/test_gemma.py was entirely @unittest.skip, so this
was never caught.
Checked that GeneNetwork2 never called these endpoints over HTTP (no
reference to api/gemma, k-compute, gwa-compute or k-gwa-compute
anywhere in its codebase) -- it runs gemma-wrapper itself directly
(wqflask/marker_regression/gemma_mapping.py), via its own
GEMMA_WRAPPER_COMMAND and os.system() calls, never through GN3's API.
So these endpoints had no real caller on either side.
Removed:
- gn3/api/gemma.py and its blueprint registration in gn3/app.py.
- generate_gemma_cmd and generate_pheno_txt_file from
gn3/computations/gemma.py (gn3/api/gemma.py was their only caller).
generate_hash_of_string stays: GeneNetwork2 imports it directly
(gemma_mapping.py, export_traits.py, views.py), and
gn3/computations/rqtl.py uses it too.
- compose_gemma_cmd from gn3/commands.py (generate_gemma_cmd was its
only caller), and the now-unused `List` import that went with it.
- tests/integration/test_gemma.py (tested only the removed blueprint).
- The generate_gemma_cmd/generate_pheno_txt_file tests from
tests/unit/computations/test_gemma.py and the compose_gemma_cmd
tests from tests/unit/test_commands.py; generate_hash_of_string's
and compose_rqtl_cmd's own tests stay.
- CACHEDIR and GEMMA_WRAPPER_CMD from gn3/settings.json: both were
read only by the removed gn3/api/gemma.py.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
|
|
|
Signed-off-by: Munyoki Kilyungi <me@bonfacemunyoki.com>
|
|
|
|
Fix the code to avoid using global variables holding configuration
variables to avoid the failures caused by action-at-a-distance effects
due to change of a value elsewhere.
This way, all code consistently receives the same configuration values
passed on from callers.
We pass on the following configuration settings:
* TMPDIR
* SQL_URI
* TEXTDIR
|
|
|
|
|
|
|
|
Signed-off-by: Munyoki Kilyungi <me@bonfacemunyoki.com>
|
|
Signed-off-by: Munyoki Kilyungi <me@bonfacemunyoki.com>
|
|
Signed-off-by: Munyoki Kilyungi <me@bonfacemunyoki.com>
|
|
Signed-off-by: Munyoki Kilyungi <me@bonfacemunyoki.com>
|
|
Signed-off-by: Munyoki Kilyungi <me@bonfacemunyoki.com>
|
|
To update an attribute, you can use the "apply_change" function
instead.
Signed-off-by: Munyoki Kilyungi <me@bonfacemunyoki.com>
|
|
Signed-off-by: Munyoki Kilyungi <me@bonfacemunyoki.com>
|
|
Signed-off-by: Munyoki Kilyungi <me@bonfacemunyoki.com>
|
|
Signed-off-by: Munyoki Kilyungi <me@bonfacemunyoki.com>
|
|
Signed-off-by: Munyoki Kilyungi <me@bonfacemunyoki.com>
|
|
Signed-off-by: Munyoki Kilyungi <me@bonfacemunyoki.com>
|
|
Signed-off-by: Munyoki Kilyungi <me@bonfacemunyoki.com>
|
|
Signed-off-by: Munyoki Kilyungi <me@bonfacemunyoki.com>
|
|
Signed-off-by: Munyoki Kilyungi <me@bonfacemunyoki.com>
|
|
Signed-off-by: Munyoki Kilyungi <me@bonfacemunyoki.com>
|
|
Signed-off-by: Munyoki Kilyungi <me@bonfacemunyoki.com>
|
|
Signed-off-by: Munyoki Kilyungi <me@bonfacemunyoki.com>
|
|
Signed-off-by: Munyoki Kilyungi <me@bonfacemunyoki.com>
|
|
Signed-off-by: Munyoki Kilyungi <me@bonfacemunyoki.com>
|
|
|
|
This reverts commit 9bad745abd94fd0eeb0b0dc6aba0d6a74db33f81.
|
|
function".
This reverts commit 6a76e302f11c0a0aa0bc0ac8487ad250f8afb9bb.
|
|
|
|
|
|
|
|
Signed-off-by: Munyoki Kilyungi <me@bonfacemunyoki.com>
|
|
|
|
|
|
|
|
* tests/unit/test_db_utils.py (test_database_connection): Delete.
Signed-off-by: Munyoki Kilyungi <me@bonfacemunyoki.com>
|
|
|
|
Update the database URI parsing to allow setting of extra connection
option on the URI string.
|
|
gn3.auth
|
|
* gn3/db/rdf/wiki.py: Delete datetime import. Import sparql_query.
[RIF_CONTEXT]: Delete.
(get_rif_entries_by_symbol): Replace CONSTRUCT with SELECT.
* tests/unit/db/rdf/test_wiki.py (test_get_rif_entries_by_symbol):
Update tests.
Signed-off-by: Munyoki Kilyungi <me@bonfacemunyoki.com>
|
|
Signed-off-by: Munyoki Kilyungi <me@bonfacemunyoki.com>
|
|
Signed-off-by: Munyoki Kilyungi <me@bonfacemunyoki.com>
|
|
* tests/unit/db/rdf/data.py: [LPL_RIF_ENTRIES]: Update "@context".
Signed-off-by: Munyoki Kilyungi <me@bonfacemunyoki.com>
|
|
* gn3/db/rdf/wiki.py: Import datetime.
[RIF_CONTEXT]: New global variable defining the json-ld context for
NCBI rif data.
(get_rif_entries_by_symbol): New function.
* tests/unit/db/rdf/data.py: New file containing expected NCBI test
data.
* tests/unit/db/rdf/test_wiki.py (test_update_wiki_comment): New test
case.
Signed-off-by: Munyoki Kilyungi <me@bonfacemunyoki.com>
|
|
Signed-off-by: Munyoki Kilyungi <me@bonfacemunyoki.com>
|
|
* tests/fixtures/rdf.py: import pathlib.
(rdf_setup): Use pathlib to get the dir name for the tests folder.
Signed-off-by: Munyoki Kilyungi <me@bonfacemunyoki.com>
|
|
* tests/fixtures/rdf.py (rdf_setup): Fix C0301.
Signed-off-by: Munyoki Kilyungi <me@bonfacemunyoki.com>
|
|
|