aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorFrederick Muriuki Muriithi2023-10-09 07:08:50 +0300
committerFrederick Muriuki Muriithi2023-10-09 07:08:50 +0300
commit1915fcdf7f67cd76348b06070e86aedfb4076f01 (patch)
tree3e58405e5053eb9cc253ea709ec278529e42706c
parent3ebf796f82797139b68f29e1e6a2323d60886539 (diff)
downloadgenenetwork2-1915fcdf7f67cd76348b06070e86aedfb4076f01.tar.gz
collections: make POST requests
Convert the requests that either create a new collection, or add traits to an existing collection to use the "POST" method, since such requests are not idempotent.
-rw-r--r--wqflask/wqflask/collect.py4
-rw-r--r--wqflask/wqflask/templates/collections/add.html7
2 files changed, 8 insertions, 3 deletions
diff --git a/wqflask/wqflask/collect.py b/wqflask/wqflask/collect.py
index c80c82cd..55d922ea 100644
--- a/wqflask/wqflask/collect.py
+++ b/wqflask/wqflask/collect.py
@@ -115,9 +115,9 @@ def __compute_traits__(params):
unprocessed_traits = params['traits']
return process_traits(unprocessed_traits)
-@app.route("/collections/new")
+@app.route("/collections/new", methods=["POST"])
def collections_new():
- params = request.args
+ params = request.form
anon_id = session_info()["anon_id"]
if "sign_in" in params:
diff --git a/wqflask/wqflask/templates/collections/add.html b/wqflask/wqflask/templates/collections/add.html
index 8640fdb8..478c80fb 100644
--- a/wqflask/wqflask/templates/collections/add.html
+++ b/wqflask/wqflask/templates/collections/add.html
@@ -5,7 +5,12 @@
or add to an existing collection.</p>
</div>
<div class="modal-body" style="margin-left: 20px;">
- <form action="/collections/new" target="_blank" data-validate="parsley" id="add_form" class="form-inline">
+ <form action="/collections/new"
+ method="POST"
+ target="_blank"
+ data-validate="parsley"
+ id="add_form"
+ class="form-inline">
{% if traits is defined %}
<input type="hidden" name="traits" value="{{ traits }}" />
{% else %}