From 1915fcdf7f67cd76348b06070e86aedfb4076f01 Mon Sep 17 00:00:00 2001
From: Frederick Muriuki Muriithi
Date: Mon, 9 Oct 2023 07:08:50 +0300
Subject: collections: make POST requests

Convert the requests that either create a new collection, or add
traits to an existing collection to use the "POST" method, since such
requests are not idempotent.
---
 wqflask/wqflask/collect.py                     | 4 ++--
 wqflask/wqflask/templates/collections/add.html | 7 ++++++-
 2 files changed, 8 insertions(+), 3 deletions(-)

diff --git a/wqflask/wqflask/collect.py b/wqflask/wqflask/collect.py
index c80c82cd..55d922ea 100644
--- a/wqflask/wqflask/collect.py
+++ b/wqflask/wqflask/collect.py
@@ -115,9 +115,9 @@ def __compute_traits__(params):
         unprocessed_traits = params['traits']
     return process_traits(unprocessed_traits)
 
-@app.route("/collections/new")
+@app.route("/collections/new", methods=["POST"])
 def collections_new():
-    params = request.args
+    params = request.form
     anon_id = session_info()["anon_id"]
 
     if "sign_in" in params:
diff --git a/wqflask/wqflask/templates/collections/add.html b/wqflask/wqflask/templates/collections/add.html
index 8640fdb8..478c80fb 100644
--- a/wqflask/wqflask/templates/collections/add.html
+++ b/wqflask/wqflask/templates/collections/add.html
@@ -5,7 +5,12 @@
         or add to an existing collection.</p>
     </div>
     <div class="modal-body" style="margin-left: 20px;">
-        <form action="/collections/new" target="_blank" data-validate="parsley" id="add_form" class="form-inline">
+      <form action="/collections/new"
+	    method="POST"
+	    target="_blank"
+	    data-validate="parsley"
+	    id="add_form"
+	    class="form-inline">
             {% if traits is defined %}
             <input type="hidden" name="traits" value="{{ traits }}" />
             {% else %}
-- 
cgit v1.2.3