aboutsummaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorPjotr Prins2017-12-07 10:17:25 +0000
committerPjotr Prins2017-12-07 10:17:25 +0000
commit031f5a94196cd177467b6ca84ce308dabc8c24bf (patch)
tree3b09d8b3407d5b737e6ea31c1415b0405980d607 /src
parent87223540e63f6da7ea085c1379deacc23b6ba5dc (diff)
downloadpangemma-031f5a94196cd177467b6ca84ce308dabc8c24bf.tar.gz
More notes and removed unused LULndet
Diffstat (limited to 'src')
-rw-r--r--src/lapack.cpp21
-rw-r--r--src/mathfunc.cpp2
2 files changed, 1 insertions, 22 deletions
diff --git a/src/lapack.cpp b/src/lapack.cpp
index 26333b6..d15446b 100644
--- a/src/lapack.cpp
+++ b/src/lapack.cpp
@@ -306,27 +306,6 @@ double LULndet(const gsl_matrix *LU) {
return gsl_linalg_LU_lndet((gsl_matrix *)LU);
}
-/*
-double LULndet(gsl_matrix_float *LU) {
- gsl_matrix *LU_double = gsl_matrix_alloc(LU->size1, LU->size2);
- double d;
-
- // Copy float matrix to double.
- for (size_t i = 0; i < LU->size1; i++) {
- for (size_t j = 0; j < LU->size2; j++) {
- gsl_matrix_set(LU_double, i, j, gsl_matrix_float_get(LU, i, j));
- }
- }
-
- // LU decomposition.
- d = gsl_linalg_LU_lndet(LU_double);
-
- // Free matrix
- gsl_matrix_free(LU_double);
- return d;
-}
-*/
-
// LU solve.
void LUSolve(const gsl_matrix *LU, const gsl_permutation *p,
const gsl_vector *b, gsl_vector *x) {
diff --git a/src/mathfunc.cpp b/src/mathfunc.cpp
index 1f24e74..644b3e8 100644
--- a/src/mathfunc.cpp
+++ b/src/mathfunc.cpp
@@ -350,7 +350,7 @@ bool isMatrixIllConditioned(const gsl_vector *eigenvalues, double max_ratio) {
auto absmax = get<2>(t);
if (absmax/absmin1 > max_ratio) {
#if !NDEBUG
- cerr << "**** DEBUG: Ratio suggests matrix is ill conditioned" << endl;
+ cerr << "**** DEBUG: Ratio |eigenmax|/|eigenmin| suggests matrix is ill conditioned for double precision" << endl;
auto t = minmax(eigenvalues);
auto min = get<0>(t);
auto min1 = get<1>(t);