about summary refs log tree commit diff
path: root/services
diff options
context:
space:
mode:
authorFrederick Muriuki Muriithi2026-06-22 11:57:02 -0500
committerFrederick Muriuki Muriithi2026-06-26 10:14:49 -0500
commit40aa65663d500c5e738787c78e39bd83096aa1c0 (patch)
tree1196286b3156248449881fbd6a55de7e8ddf3b27 /services
parent2fdba37fe26ff3c24f5cfae040d2098c31cf30c2 (diff)
downloadgn-machines-40aa65663d500c5e738787c78e39bd83096aa1c0.tar.gz
Bugfix: with-directory-excursion fails attempting to restore dir
The `with-directory-excursion' macro changes to the specified directory on
entry, runs the code it was provided in that directory then on completion, it
changes back to the directory the original code that called it was in.

Herein lies the problem, the change in directories (entry and exit) only work
if the directory permissions allow. In our case, the `gn-auth-test-flask' gexp
is to be called with `sudo -u genenetwork ...'. This means that while it will
successfully enter into the directories owned by the "genenetwork" user, it
will fail when attempting to exit back into the
"/tmp/gn-integration-tests.XXXXXX" temporary directories (#o700) owned by the
"laminar" user.

This commit changes the git command, providing it the "-C" path to the
repository, thereby circumventing the need to enter and exit directories that
might cross "permission" boundaries.

The commit also removes the duplicated logging within the
`gn-integration-tests-gexp' gexp. Instead, we show the commits within the
`gn-auth-test-flask' gexp that's run under the "genenetwork" user (sudo -u
genenetwork ...) and therefore has the appropriate permissions to access the
checkout directories.
Diffstat (limited to 'services')
0 files changed, 0 insertions, 0 deletions