| Age | Commit message (Collapse) | Author |
|
Found by an exhaustive small-payload fuzz (test/fuzz_bnw.py):
- bn_genenet.php: fail fast with a plain-English problem list for
header-only payloads, ragged rows, single variable/sample, all-NA
columns and all-NA rows, non-numeric cells and empty payloads;
normalize CRLF and squeeze redundant row separators; rename
duplicate variable names with a note (prep used to crash on each
of these deep inside octave)
- runtime_check.php: exe_time no longer fatals ("int + string") when
prep did not produce its tables; falls back to a default estimate
- execute_bn_gom.php: the FAILED page gains plain-English hints for
the recurring octave failure modes
- test/bnw_http_tests.py: tests t22-t33 lock the behaviour in
- test/fuzz_bnw.py: the parameter-space fuzzer (75 cases)
|
|
runTerminalCommand throws a RuntimeException when run.sh or
run_octave fails, and execute_bn_gom.php had no try/catch -- the
uncaught exception produced a blank page with no forward and no
diagnosis (observed on production with real GeneNetwork datasets).
Wrap the structure-learning pipeline in try/catch and render the
error on the status page ("Structure learning FAILED: ..." plus a
link back to the upload page) instead.
|
|
The runner page used to output NOTHING until the C structure learning
and octave runs finished (~12s+); the browser sat on a blank page and
only then got the window.open forward to the network diagram. Emit a
status page first (flushed before the work starts):
Structure learning is running.
Forwarding to the network diagram when done...
If the diagram does not open, click here. (link to
layout_svg_no.php?My_key=...)
so users get feedback during the run and a manual fallback if the
automatic forward is blocked or fails.
|
|
Changes previously carried as bnw-container-paths.patch in
guix-bioinformatics, now applied to the source directly:
* unify data directories on /var/lib/genenet/bnw (was /tmp/bnw and
./data/ mixed)
* make the shell_exec paths __DIR__-relative and the example/octave
helper scripts location-independent, so php-fpm can run them from
any working directory
* use core-octave randn/exp instead of the statistics-package
normrnd/normpdf (not available in the container's octave)
* nnodes: strtrim before strfind so the node count parses with the
container's octave output
* python3 instead of a hardcoded /home/jziebart path
* add diag.php, a debug page showing the request and data state
* bn_genenet.php: serve the GeneNetwork (GN2) handshake server-side;
the My_Gennenet POST is converted (commas -> tabs, semicolons ->
newlines) in PHP and the prepared-data page is returned in ONE
request. This removes the raw-echo of into a JavaScript
string (an XSS hole on public deployments) and is backward
compatible for GN2 (same POST, better response).
|
|
|
|
On PHP 7.4, calling fwrite()/fprintf()/fclose() with a false handle
(a failed fopen(), e.g. from a bad path, missing directory, or
permissions issue) just emits a warning and no-ops. On PHP 8.0+, these
functions require a resource argument and throw an uncaught TypeError
instead, turning what used to be a silent degradation into a fatal
crash of the whole request.
This patch wraps every fopen()-then-write call site in the codebase
(18 files) with an `if ($handle !== false) { ... }` check, matching
the existing pattern used elsewhere in the codebase. Where the same
$fpvar handle is threaded through shared helper functions
(enter_ban_list/banlist/whitelist, duplicated across
remove_variables_processing.php, remove_variables_processing_default.php,
modify_structure_learning.php and tier_description_processing_gom.php),
the guard was added inside those functions too for consistency, even
though the call sites are currently dead/commented-out in three of the
four files — so the same landmine doesn't reappear if that code is
ever re-enabled.
Verified empirically against PHP 8.3.28: fopen() on an unwritable path
followed by fwrite() on the resulting `false` throws
TypeError: fwrite(): Argument #1 ($stream) must be of type resource, false given
without the guard; with the guard, the call is skipped instead of
crashing. The normal (successful fopen) path was also re-run through
mat_structure.php's structure_change() and still produces identical
output to before the change.
Reviewed by: Frederick M Muriithi <fredmanglis@gmail.com>
|
|
|
|
|
|
|
|
The main change here is in the parameter learning methods. The parameters that are learned at first (i.e., if there is no evidence) are the distributions that are found directly in the data. I had to create or significantly modify several BNT files for this.
If there is evidence, the parameters are learned using a Dirichlet prior. This only required a couple of small changes to the BNW parameter learning files.
|
|
|
|
This version of BNW should perform the same as the original version. The only difference is that it uses Octave instead of Matlab when running BayesNet Toolbox during parameter learning.
I am calling this BNW_1.02. It can be accessed at:
compbio.uthsc.edu/BNW_1.02
|
|
|