| Age | Commit message (Collapse) | Author |
|
BNW's computation does not need the web application: run.sh drives three C
programs over files in a per-run directory, and everything above that is file
assembly and rendering. bin/bnw does the same pipeline -- network_score, the
k-best search, structure -- in a private working directory, and reports one row
per candidate edge with its posterior and whether it survived the threshold.
The reference for all of it is the running bnw-container, not a memory of it:
its six continuous traits example was run through the web application
(bn_genenet.php -> execute_bn_gom.php) and the resulting files kept as fixtures
in test/golden/. test/parity_check.py compares our continuous_input.txt and
structure_input.txt against those, and the driver's own stdout against the
file. Today: byte-identical, 5 edges.
Four things that run settled, each of which had been guessed wrong or not at
all:
* continuous_input.txt is header, then a TYPE LINE (1 = continuous, n =
n-level discrete), then data. network_score reads the type before the
data, and the web application's file is one line longer than the matrix
because of it. Without the line the first data row shifts and
network_score segfaults.
* structure exits with an uninitialised status while writing a correct file.
The web application ignores the status; the driver now judges it by its
output and only fails if the file is missing.
* get_kbest_nets.cc used SGI's <ext/hash_set>, which modern libstdc++ no
longer has. It now uses std::unordered_set with an explicit hasher
(specialising std::hash for a pointer type is not allowed), and build.sh
compiles the C with -std=gnu89 because the sources predate C99.
* our run leaves postProbEachEdge.txt with per-edge posteriors; the web
application's flow leaves none behind, so the posteriors are information
the endpoint can report that the web app never showed.
Exit codes are part of the contract GN4 will code against: 0 ok, 2 bad input,
3 the computation failed, 77 the binaries are not installed (a conventional
skip, so a test suite can run where BNW is not).
Build output is gitignored. AI plan and status updated in
info_files/gn4-integration-plan.md; README gained a "Headless driver" section.
|
|
The hook was removed from guix-bioinformatics/gn/packages/bnw.scm;
the container tests now always build the package from the git origin
pinned there (git.genenetwork.org), so push to gn-bnw main (or update
the pin) before testing source changes.
|
|
guix-bioinformatics
The pinned container keys are generated by hand in $HOME and never
enter a repository; the test runner now ssh-es with
$HOME/hello-container-key (CLIENT_KEY override). Also documents
restoring gn/packages/bnw.scm from guix-bioinformatics' BNW branch —
without it the build silently falls back to unpatched upstream BNW.
|
|
'make test' builds the BNW package from this checkout (BNW_LOCAL_SOURCE
in guix-bioinformatics) and runs the full container test cycle; 'make
run' leaves the container up on :8881; 'make clean' removes test logs,
the /tmp VM image and leaked test VMs.
|
|
|
|
GN2 posts My_Gennenet to bn_genenet.php (commas = columns,
semicolons = rows); the page converts it client-side to TSV in the
hidden searchkey field and auto-submits. The new tests cover the
entry point (t18: payload embedded in genenetwork_data() + auto-submit
stub), the browserless emulation of the conversion (t19: searchkey/
My_key/MyUpload=NO posted directly, data prepared), and a full GN2
driven structure learning + rendering (t20). 25 checks pass via
test/run_container_tests.sh.
|
|
test/run_container_tests.sh builds the bnw-container definition,
starts it through the run-guix-system-container daemon, waits for the
web server on port 8881, runs the 22-check HTTP suite and the
container tool check over ssh, and stops the container (kept on
failure or --keep for debugging).
|
|
Parametrize the example test over every example.php link on
workflow.php (example2, example_sci, example_chr2_spleen,
example_chl, example_time_series, examplecar15node): each loads the
pre-computed example state into a fresh key and renders its network
via layout_svg_no.php. All 20 checks pass.
|
|
test/bnw_http_tests.py drives a running BNW over plain HTTP requests
(no headless browser): static pages, key handling, upload + octave
input preparation, structure learning, network rendering and the
worked examples from workflow.php, for both a discrete (8-node) and a
continuous (5-node) dataset. 15 checks, all passing against the
Guix container build of the upgraded tree.
test/check_container_tools.sh verifies every unix tool called
externally (octave, dot, python3, the compiled scoring binaries,
coreutils glue) exists in the deployment environment.
README documents the test suite, the external tool inventory and the
PHP8/container issues the tests uncovered (mixed /tmp/bnw and
/var/lib/genenet/bnw data dirs, home.php redirect stub, broken
keyval_error redirect, hardcoded python path).
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|