about summary refs log tree commit diff
path: root/test/python/test_group_traits.py
diff options
context:
space:
mode:
authorPjotr <wrk@bosa.lan>2026-10-08 06:53:15 +0000
committerPjotr <wrk@bosa.lan>2026-10-08 06:53:15 +0000
commit54f138802bed2040531b3da3df0b30895d881bc8 (patch)
treef334657d04e488f808d2d1bcd7931755427b299d /test/python/test_group_traits.py
parentdfd4bf042cce290a103f83ce19df5a4781e51c17 (diff)
downloadgenenetwork4-54f138802bed2040531b3da3df0b30895d881bc8.tar.gz
* src/routes/publications.rs: add GET /publications/{pubmed_id}/traits.
Lists the published traits (across groups) a publication reports.
Datasets the caller may not view are left out, using the same check as
GET /traits/{dataset} (traits.rs is_authorised is now pub(crate)).

* src/db.rs (TraitInfo, trait_info_sql): TraitInfo gains `dataset`,
`abbreviation` (Phenotype.Post_publication_abbreviation, else Pre) and
`url` (the GeneNetwork show_trait page). The three TraitInfo queries
now share one SELECT. New get_group_traits_by_abbreviation and
get_publication_traits.
* src/routes/groups.rs (group_traits): add ?abbreviation= filter.
* src/db.rs (Group), src/routes/groups.rs (groups): groups carry
`family` and `species`; add family, species and q filters.
* src/routes/search.rs (search): add `page` (gn3's page unsorted, a
page of the ranked list with `sort`); declare `pubmed_id`; hits gain
`abbreviation` next to `locus` (get_publish_annotations).
* src/db.rs (LRS_PER_LOD): LOD = LRS / 4.604, the divisor the
benchmark's RDF data uses (was 4.61).

* tests, test/python, test/data/benchmark_search.json, README.md: cover
all of the above; tests/benchmark.rs now also answers rows 11, 16, 25,
30, 34 and 37 of small_benchmark.csv, and compares LOD exactly.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Diffstat (limited to 'test/python/test_group_traits.py')
-rw-r--r--test/python/test_group_traits.py21
1 files changed, 21 insertions, 0 deletions
diff --git a/test/python/test_group_traits.py b/test/python/test_group_traits.py
index d918688..c9d2125 100644
--- a/test/python/test_group_traits.py
+++ b/test/python/test_group_traits.py
@@ -64,6 +64,27 @@ class GroupTraitsTest(ServerTestCase):
         self.assertEqual(error["operation_id"], "group_traits")
         self.assertEqual(error["next"], "/groups")
 
+    def test_group_traits_filters_by_abbreviation(self):
+        if not database_reachable():
+            self.skipTest("no database on 127.0.0.1:3306")
+
+        response, body = self.get("/groups/BXD/traits?abbreviation=5HT_MB_M")
+        self.assertEqual(response.status, 200)
+        traits = json.loads(body)
+        self.assertEqual(len(traits), 1)
+        self.assertEqual(traits[0]["id"], 17985)
+        self.assertEqual(traits[0]["abbreviation"], "5HT_MB_M")
+        self.assertEqual(traits[0]["dataset"], "BXDPublish")
+        self.assertEqual(
+            traits[0]["url"],
+            "https://genenetwork.org/show_trait?trait_id=17985&dataset=BXDPublish",
+        )
+
+        # An unknown abbreviation is an empty list, not an error.
+        response, body = self.get("/groups/BXD/traits?abbreviation=no_such_trait")
+        self.assertEqual(response.status, 200)
+        self.assertEqual(json.loads(body), [])
+
 
 if __name__ == "__main__":
     unittest.main()