about summary refs log tree commit diff
path: root/test/python/test_envelope.py
diff options
context:
space:
mode:
authorPjotr <wrk@bosa.lan>2026-10-15 12:51:49 +0000
committerPjotr <wrk@bosa.lan>2026-10-15 12:51:49 +0000
commit7f56f54622c704840c34e2b8f289bdb5220e9975 (patch)
treedb743d5ffd9a83cc24f0a7197beb3b8295468e59 /test/python/test_envelope.py
parenta7d69da70e98bf8cef1e6ec11000714831dd6853 (diff)
downloadgenenetwork4-7f56f54622c704840c34e2b8f289bdb5220e9975.tar.gz
gemma: scatter ravanan's --loco workflow by chromosome via CWL scatter
Replace gemma-loco.cwl's single kinship/gwa pair (each one gemma-wrapper
invocation covering all chromosomes, relying on gemma-wrapper's own
internal GNU-parallel fan-out) with one gemma-wrapper invocation PER
CHROMOSOME, restricted via its existing --chromosomes/--no-parallel
flags and scattered by ravanan itself (ScatterFeatureRequirement,
scatterMethod: dotproduct). gemma-wrapper still does the correct
per-chromosome LOCO math (exclude this chromosome from kinship, test
only its markers) against the full genotype/SNP files -- only which
chromosome(s) it loops over changes. compute_ravanan now computes the
chromosome list itself (chromosomes_in, mirroring gemma-wrapper's own
get_chromosomes) and passes it as the workflow's scatter input, and
collates the resulting per-chromosome gwa_json/archive array outputs.

Measured 16.7s wall-clock end-to-end against the BXD fixtures (20
chromosomes), vs. ~19s for /compute/gemma's direct path and ~21s for
the previous sequential ravanan workflow -- confirmed byte-for-byte
identical output (rs31443144's exact values, 7320 total rows).

Also fixes three real, previously-unexercised bugs in compute_ravanan
found getting this to run at all (POST /compute/gemma/ravanan had no
automated test until this commit):
- missing --guix-manifest (ravanan requires it; added
  gemma_ravanan_manifest config key and cwl/gemma/manifest.scm)
- missing --store files/logs/data subdirectories (ravanan does not
  create them itself)
- --output-directory dropped entirely: every chromosome's gwa archive
  shares gemma-wrapper's own content-hash basename (the hash doesn't
  factor in --chromosomes), so ravanan's optional flat-symlink step
  collides across them; unneeded anyway since results are read
  straight from ravanan's --store via its stdout JSON record.

Also found and worked around a ravanan scheduler bug: a step scattered
over exactly one input needs an explicit scatterMethod even though CWL
only requires one for multiple scattered inputs -- ravanan has no
fallback case for a missing one and silently misbehaves.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Diffstat (limited to 'test/python/test_envelope.py')
0 files changed, 0 insertions, 0 deletions