about summary refs log tree commit diff
path: root/src
diff options
context:
space:
mode:
authorPjotr <wrk@bosa.lan>2026-11-11 13:07:03 +0000
committerPjotr <wrk@bosa.lan>2026-11-11 13:07:03 +0000
commitf4d2d719f90774e85bc47eca041bc469f0f0951d (patch)
treeb31f206be9e954cc11de6db5523438e9521e1164 /src
parentc9db07f6d372b0b8812e5f6698257a9df94dc1ef (diff)
downloadgenenetwork4-f4d2d719f90774e85bc47eca041bc469f0f0951d.tar.gz
gemma: the permutation refusal names both routes, including running GEMMA itself
We do not run GEMMA permutations -- each repeats the whole LOCO scan and the
gate gives GEMMA one slot -- but "not supported here" is not the same as
"not available". The refusal now says both:

  1. POST /compute/bulklmm with nperm: 1000 -- an LMM whose thresholds come
     from rotations that keep the kinship (R/qtl's nperm does not, and is
     anti-conservative on a structured panel);
  2. run GEMMA's own permutation locally. The reply's notes already name the
     bimbam pair and the phenotype file, so `gemma-wrapper --permutate` or
     `gemma -lmm 9 --permutate` on those inputs reproduces exactly the null
     GEMMA would have used -- hours instead of seconds, which is the honest
     price of that particular null.

docs/bulklmm.md gains the table this belongs in: three ways to get a
threshold, ordered by how honest the null is for a structured panel
(rotation with kinship; GEMMA's own LOCO permutation run locally; R/qtl's
nperm as a sanity check only). SKILL.md says the same in two lines.

tests/gemma.rs now asserts both halves of the refusal, and the earlier
assertion on /compute/rqtl -- which stopped being true when the refusal was
rewritten -- is replaced rather than left passing by accident.
Diffstat (limited to 'src')
-rw-r--r--src/routes/gemma.rs17
1 files changed, 11 insertions, 6 deletions
diff --git a/src/routes/gemma.rs b/src/routes/gemma.rs
index 79bc445..bfb483a 100644
--- a/src/routes/gemma.rs
+++ b/src/routes/gemma.rs
@@ -304,12 +304,17 @@ pub async fn compute_gemma(
                 "{requested_permutations} permutations requested, but this endpoint runs none: \
                  each one repeats the entire LOCO association scan (gemma-wrapper --permutate), \
                  so a thousand is thousands of scans and hours of the one slot GEMMA has here. \
-                 For significance thresholds, send the same trait values to POST /compute/bulklmm \
-                 with \"nperm\": 200: it fits an LMM with a global kinship matrix and permutes by \
-                 rotating the data through that matrix, so the thresholds belong to a mixed \
-                 model (R/qtl's nperm works too, but its null ignores relatedness). Judge a GEMMA \
-                 peak against whichever threshold you use, or against the smallest p_lrt it \
-                 reached -- and remember BulkLMM is global-kinship, not LOCO."
+                 Two ways to get a threshold instead: (1) send the same trait values to \
+                 POST /compute/bulklmm with \"nperm\": 1000 -- it fits an LMM and permutes by \
+                 rotating the data through the kinship decomposition, so its thresholds respect \
+                 relatedness (R/qtl's nperm does not, and is anti-conservative on a structured \
+                 panel); (2) run GEMMA's own permutation locally on the same inputs -- the files \
+                 this endpoint used are named in the reply's notes (the bimbam pair and the \
+                 phenotype file), so `gemma-wrapper --permutate` or `gemma -lmm 9 --permutate` \
+                 reproduces exactly the null GEMMA would use, at hours rather than seconds. \
+                 Judge a GEMMA peak against whichever threshold you choose, or against the \
+                 smallest p_lrt it reached -- and remember BulkLMM's kinship is a single \
+                 genome-wide matrix, not LOCO like this scan."
             ),
             "compute_gemma",
         )