| Age | Commit message (Collapse) | Author |
|
A commit that only adds a file recorded nothing: git has no before-side for
the new file, so its hunks carry no context ("@@ -0,0 +1,207 @@"), and Python
and Ruby had no declaration scanner to fall back on. Adding
bin/geno2mdb.py to gemma-wrapper left one commit row and two reasoning
entries with no symbol at all, so `why` could not reach them while `search`
and `list` could.
Both languages are now scanned line by line, which is the right tool here:
in Python and Ruby a declaration is the first token on its line, so the
keyword decides -- `def foo(bar):` declares, `foo(bar)` calls -- the
distinction no C++ line scanner can make.
Python def / async def -> fn, class -> type, and at column 0 only
NAME = value -> const, NAME: Type -> var (an indented assignment
is a local inside a def)
Ruby def / def self.NAME (with ? ! = suffixes) -> fn, class / module ->
type, and a column-0 capitalised NAME = value -> const
An added file needs no special case: every one of its lines is a '+' line,
which git_touched already walks, so the same path that records an added line
in an existing file now records a new file's declarations. Names strip .py
and .rb like .odin and .rs (script.helper); the C family keeps its extension
because a header declaration and the source definition are different rows.
The lookup's last resort was `s.name like '%name'` -- a suffix match -- so
`why geno2mdb` could never find a file's own symbols even though SKILL.md
documents a LIKE '%...%' scan. It is a substring match now, so the file base
works, and the doc is true again.
The check phase commits script.py and script.rb into its throwaway
repository and asserts both land as `add` rows and that `why script`
resolves; measured on gemma-wrapper, sync adds 344 touches over 319 commits
and `why read_snps` reaches the reasoning attached to the commit that
introduced it.
|
|
C and C++ were the one language family where the store could only say "a hunk
landed inside this function". A diff line cannot be read for declarations
there: inside a body `foo(bar);` calls something, inside a class body the same
bytes declare a constructor, and pangemma indents both the same way (of 248538
changed lines in its history, 14991 are indented `name(` lines, and the most
frequent are calls). So the file is handed to universal-ctags and the tags of a
commit's blob are diffed against its parent's: present only in the new blob is
an add, only in the old one is a remove, and a name whose tag survives both is
left to hunk context, which is the honest answer for "the change was inside
this".
The cost is bounded by a cache keyed by git object id (new table `blobs`): a
blob's tags can never change, so each file version is parsed once per store.
On the pangemma history (688 commits, 1163 distinct C/C++ blobs) the first full
pass takes 26 s and touches go from 1404 context-only rows to 6888 add, 5125
remove, 1505 context; the second pass takes 11 s and runs no ctags at all.
ctags is optional at run time. Without it the store behaves exactly as before
and `sync` says so once. The Guix package bakes its absolute path into
$AI_MEMORY_CTAGS through wrap-program, and the check phase now builds a
two-commit git repository with one C++ file to prove it end to end: the
function added in the second commit is `add`, the one whose body changed is
`context`.
Details found by running it on a real history, all in this commit:
- lambdas are tagged by default under names ctags derives from a hash of the
file (`__anon426fc91f0102`), so every touched file reported seven functions
added and seven removed per commit; `--extras=-{anonymous}` turns them off.
- `--kinds-C++=+p` is needed or prototypes are invisible and a declaration in a
header would never be seen.
- include guards (`#define CALC_H`, `#define __CALC_H__`) are filtered: they are
bookkeeping, while other macros are kept as `const`.
- merge_decl keyed a commit's declarations by bare identifier, so two files
declaring the same name in one commit collided and one lost its attribution.
It is keyed by (file, name) now -- a bug that applied to Odin and Rust too.
|
|
A gist is a judgement about what an entry claims, so it must not drift once
made. The store did not hold that invariant: db_backfill_gist ran
update reasoning set gist = ?1 where id = ?2
for every row, so any migration that re-derived gists would have replaced
every assessed --gist with the body's first sentence. It only escaped
notice because the backfill happens to run once, on the version 3 -> 4
upgrade.
reasoning.gist_source now says how each gist came about -- 'assessed' when
the caller said what the entry claims (--gist), 'derived' when it is the
body's first sentence -- and the backfill is guarded:
where gist is null or gist_source = 'derived'
so a derived gist may be recomputed when the derivation improves, and an
assessed one is frozen for the life of the entry. Version 5 of the schema
adds the column; a store that predates it cannot say which of its gists were
assessed, and the two mistakes are not equal -- labelling an assessed gist
derived lets a later migration overwrite a judgement, while labelling a
derived one assessed merely freezes a first sentence -- so existing gists
become 'assessed' and only rows with no gist are left to the backfill.
test/gist_immutable.sh pins it: record one assessed and one derived gist,
set user_version back to 3 so the next open re-runs the migration, and assert
both are byte-identical afterwards. Against the old backfill the assessed
one changes and the test fails.
Measured on the production store (139 entries, version 4): the migration to 5
kept every gist and labelled all 139 assessed, no gist was blanked, and
listings (log, why, search) are unchanged. Two new entries came out as
expected: ('Derived one', derived) and ('Assessed one', assessed).
|
|
`ai-memory record --commit 1ae2f5d` (a short hash) answered
imported 1ae2f5d (qtl2: permutations for the LOD thresholds)
ai-memory: sql error (Error): SQL logic error
and left the store half-updated: the commit row was imported under its full
hash, the reasoning row was not written at all, and the message named neither
the cause nor the fix. Feed the same command the full forty characters and it
worked, which is the sort of difference that reads as flakiness.
Three changes, in the order they matter:
* resolve the ref first. record's --commit and attach's positional argument
both go through resolve_commit_ref, which asks git (`rev-parse --verify`) and
keeps the full hash; if git does not know the ref the command refuses before
opening a transaction, says which ref and which repository, and suggests
--commit none plus a later attach. The store keys commits by the full hash,
so a short ref written to reasoning.commit_hash names a row that cannot exist.
* one transaction around the import and the insert (begin immediate ... commit,
rollback on any failure), so a failed record leaves a store that looks exactly
as it did. Verified against a store whose schema predates the binary: no new
commit row survives the failure.
* an actionable message: an empty sqlite3 errmsg on SQLITE_ERROR now says the
store's schema is older than the binary and to run init, instead of "sql
error (Error):" with nothing after it.
Measured, fresh store: --commit 1ae2f5d records against
1ae2f5d712e18c016fdb7bd04da99eab4da6915b; --commit deadbeef refuses and writes
nothing; --commit HEAD~1 resolves; attach 1ae2f5d links an unattached entry.
|
|
list, why, search and log printed either nothing or a full ISO timestamp, and
a stamp that wide pushes the hash and the gist apart. One helper, fmt_date,
renders UTC dd/mm and adds the year only when it is not the current one; an
unattached entry is dated by when it was written, since it has no commit date.
|
|
`list`, `why` and `search` were truncating bodies at 96 characters, which
keeps whatever happens to come first -- usually the least informative clause
of the entry ("Only the range or every chromosome?...").
reasoning.gist (schema v4) holds the claim on one line, written at record
time via --gist. Listings show it; --full adds the body beneath. Existing
entries are backfilled from their first sentence, which is a floor, not an
equivalent: it says what the entry is about. Recording without --gist still
works and says so on stderr.
|
|
why SYMBOL and search both need a starting point -- a symbol name or a word
you already know. `list` is the inventory: short hash, entry id, kind, and
the body flattened to a line. Unattached entries sort first and read
"uncommitted"; a superseded entry reads "kind->#N". --session, --kind and
--commit narrow it.
|
|
SQLite stays the truth; this is a derived index that lets a reader enter by
concept rather than by symbol. Two commands, one prefix vocabulary:
ai-memory --index DIR update-index [--rebuild]
ai-memory --index DIR search 'topic:pve repo:genenetwork4'
Prefixes: topic:, repo:, type: (reasoning|commit), session:, commit:,
date:. Free text is stemmed; default operator AND, --or to widen. Topic
terms come from the session id split on hyphens, so a session named
"gemma-pve" answers topic:pve and topic:gemma -- naming a session after a
concept is how an entry becomes findable by it.
Why Guile and a subprocess: libxapian is C++-only, so a foreign call from
Odin means a hand-written C shim with its own exception boundary; guile-xapian
already ships one, tested and maintained. So scripts/index.scm owns every
Xapian call (426 lines: schema constants, record builders, updater, query
parser, JSON writer) and ai-memory shells out to it -- index.odin is 145 lines
of process plumbing. The boundary is a store path in and JSON out, which also
means the search reply needs no parser on this side.
Incremental in the way that matters: documents are deleted by their unique
term and re-added, and Xapian applies that as changed postings only. The whole
body is re-tokenised each run (~1 s at a few hundred documents) which buys not
keeping any "what did I index last time" state that could go stale. Two
discoveries shaped it, both from guile-xapian 0.4.0's SWIG surface: replace by
term silently appends (the string lands on the docid overload), so delete then
add; and Database-get-document by term returns nothing, so no digest compare
was attempted.
The package's check phase now exercises it end to end -- throwaway store,
one entry, update-index, then `search topic:index | grep -q '"count":1'` --
because a check that only links proves nothing about the four Guile
dependencies. guix.scm installs scripts/index.scm to share/ai-memory (where
index.odin looks) and wraps the binary with GUILE and GUILE_LOAD_PATH for
guile-xapian and guile-sqlite3.
doc/SKILL.md gains the usage, the prefix list and the reason for the
subprocess.
|
|
`insert or ignore' returns success for a touch that already exists, so the
old counter reported every re-sync as if it had imported the whole history
again. Count the table rows before and after instead.
|
|
commits, symbols and touches are derived from `git log`/`git show` by
`sync`; only reasoning is authored, and it is append-only. Each entry
records a basis (how it was established) and may supersede an earlier
entry instead of rewriting it.
Symbols come from two signals: declarations added or removed on diff
lines (Odin and Rust), and the enclosing item named in git's own hunk
headers, which needs no parser and works for any language with a
userdiff driver.
Links SQLite through the odin-sqlite3 bindings; guix.scm builds both the
compiler and the tool. doc/SKILL.md is the operating guide.
|