Fix linting issues.

3 files changed, 9 insertions, 9 deletions

diff --git a/uploader/publications/models.py b/uploader/publications/models.py
index f37b67d..f83be58 100644
--- a/uploader/publications/models.py
+++ b/uploader/publications/models.py
@@ -30,6 +30,7 @@ def create_new_publications(
         conn: Connection,
         publications: tuple[dict, ...]
 ) -> tuple[dict, ...]:
+    """Create new publications in the database."""
     if len(publications) > 0:
         with conn.cursor(cursorclass=DictCursor) as cursor:
             cursor.executemany(
@@ -47,7 +48,8 @@ def create_new_publications(
             return tuple({
                 **row, "publication_id": row["Id"]
             } for row in cursor.fetchall())
-        return tuple()
+
+    return tuple()
 
 
 def update_publications(conn: Connection , publications: tuple[dict, ...]) -> tuple[dict, ...]:
diff --git a/uploader/publications/pubmed.py b/uploader/publications/pubmed.py
index e8b0584..2531c4a 100644
--- a/uploader/publications/pubmed.py
+++ b/uploader/publications/pubmed.py
@@ -29,9 +29,7 @@ def __journal__(journal: etree.Element) -> dict:
     }
 
 def __author__(author: etree.Element) -> str:
-    return "%s %s" % (
-        author.find("LastName").text,
-        author.find("Initials").text)
+    return f'{author.find("LastName").text} {author.find("Initials").text}'
 
 
 def __pages__(pagination: etree.Element) -> str:
diff --git a/uploader/publications/views.py b/uploader/publications/views.py
index e7aa412..a88f754 100644
--- a/uploader/publications/views.py
+++ b/uploader/publications/views.py
@@ -27,21 +27,21 @@ pubbp = Blueprint("publications", __name__)
 @require_login
 def index():
     """Index page for publications."""
-    with database_connection(app.config["SQL_URI"]) as conn:
-        return render_template("publications/index.html")
+    return render_template("publications/index.html")
 
 
 @pubbp.route("/list", methods=["GET"])
 @require_login
 def list_publications():
+    """Fetch publications that fulfill a specific search, or all of them, if
+    there is no search term."""
     # request breakdown:
     # https://datatables.net/manual/server-side
     _page = int(request.args.get("draw"))
     _length = int(request.args.get("length") or '-1')
     _start = int(request.args.get("start") or '0')
     _search = request.args["search[value]"]
-    with (database_connection(app.config["SQL_URI"]) as conn,
-          conn.cursor(cursorclass=DictCursor) as cursor):
+    with database_connection(app.config["SQL_URI"]) as conn:
         _publications, _current_rows, _totalfiltered, _totalrows = fetch_publications(
             conn,
             _search,
@@ -73,7 +73,7 @@ def view_publication(publication_id: int):
 @require_login
 def create_publication():
     """Create a new publication."""
-    if(request.method == "GET"):
+    if request.method == "GET":
         return render_template("publications/create-publication.html")
     form = request.form
     authors = form.get("publication-authors").encode("utf8")