about summary refs log tree commit diff
diff options
context:
space:
mode:
authorFrederick Muriuki Muriithi2025-07-24 13:37:22 -0500
committerFrederick Muriuki Muriithi2025-07-24 13:37:22 -0500
commit8e4ebe14da610de84cd1f53eb491e7c50cd3d781 (patch)
treec80c418d81f0189d012c0268c21b62857084521a
parent659d9afedc75aecc05b7eddd2cefa0b45e5162b9 (diff)
downloadgn-libs-8e4ebe14da610de84cd1f53eb491e7c50cd3d781.tar.gz
Deactivate a check that's likely wrong - add a note. privileges-checking2
-rw-r--r--tests/unit/test_privileges_spec_parsing.py16
1 files changed, 10 insertions, 6 deletions
diff --git a/tests/unit/test_privileges_spec_parsing.py b/tests/unit/test_privileges_spec_parsing.py
index 88b15fc..124f570 100644
--- a/tests/unit/test_privileges_spec_parsing.py
+++ b/tests/unit/test_privileges_spec_parsing.py
@@ -153,12 +153,16 @@ def test_complex(spec, expected):
 @pytest.mark.unit_test
 @pytest.mark.parametrize(
     "spec,expected",
-    (("(AND priv1 (or priv2 priv3) priv4 (or priv5 priv6))",
-      ("AND",
-       ("priv1", "priv4"),
-       ("OR", ("priv2", "priv3", "priv5", "priv6")))),
-     ("(OR priv1 (or priv2 priv3 (or priv4 priv5)) (or priv6 priv7))",
-      ("OR", ("priv1", "priv6", "priv7", "priv2", "priv3", "priv4", "priv5")))))
+    (
+        # -- We need to be careful about reduction --
+        # -- Please revisit your boolean logic to verify --
+        # -- how to reduce boolean statements. --
+        # ("(AND priv1 (or priv2 priv3) priv4 (or priv5 priv6))",
+        #  ("AND",
+        #   ("priv1", "priv4"),
+        #   ("OR", ("priv2", "priv3", "priv5", "priv6")))),
+        ("(OR priv1 (or priv2 priv3 (or priv4 priv5)) (or priv6 priv7))",
+         ("OR", ("priv1", "priv6", "priv7", "priv2", "priv3", "priv4", "priv5"))),))
 def test_reduction(spec, expected):
     """
     GIVEN: A spec that can be reduced