summaryrefslogtreecommitdiff
path: root/issues/systems/mariadb/move-to-innodb.gmi
blob: 13fecce21014c7186d204a91bb73fb3c50eda9a4 (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
# MariaDB: Move to InnoDB Engine

We are going to move from myisam to innodb. Penguin2 has been happily running innodb for some time.

Main problem are fulltext columns, the text from Trello is captured below. This is for the following tables

* ProbeSet
* GeneRIF_BASIC
* pubmedsearch

Initial good candidates are (from issues/database-not-responding):

* Good candidates
  + 2.1G Dec  4 22:15 ProbeSetXRef.MYD (done!)
  + 2.3G Dec 18 14:56 ProbeSet.MYD - with fulltext column
  + 2.6G Aug 27  2019 ProbeSE.MYD (used?)
  + 7.1G Nov  2 05:07 ProbeSetSE.MYD (done!)
  +  11G Aug 27  2019 ProbeData.MYD (used?)
  +  63G Dec  4 22:15 ProbeSetData.MYD

I am starting with the two SE tables first - because they are small.

Actually ProbeData and ProbeSE (containing the Affy data) are not referenced in GN2. I need to check that.

## Report

With the SQL database we need to move from myisam to innodb format,
mostly to stop the problem of full table locks. Also I expect the
occasional crashes we see to go away.

Today, as a start, I moved the ProbeSetSE table to innodb. The result
is that the disk representation is 3x the size and a full table scan
takes 3x the time (somewhat unsurprising). This may impact
correlation, i.e. those routines that go through all the data. We'll
have to test that carefully. For the SE I don't think we do that, so
it is no biggie.

There are no real performance gains that I can tell, though for the
mapping page I see no slowing down either.

I'll need to free up space on the NVME storage to do the larger
tables.

I also took the opportunity to add a primary key because InnoDB
requires it and I changed the *table* language from latin1-sweden to
utf8. These are major upgrades.

There are no real performance gains that I can tell, though for the
mapping page I see no slowing down either.

I'll need to free up space on the NVME storage to do the larger
tables.

I also took the opportunity to add a primary key because InnoDB
requires it and I changed the *table* language from latin1-sweden to
utf8. These are major upgrades.

In the coming week I'll have to reboot the server to add a disk, move
stuff across to free up space on the NVME, and convert a few more
tables. I aim to get the largest tables done - because these are the
one that hurt when locked:

* Good candidates with update times
  + 2.1G Dec  4 22:15 ProbeSetXRef.MYD
  + 2.3G Dec 18 14:56 ProbeSet.MYD - with fulltext column
  + 2.6G Aug 27  2019 ProbeSE.MYD
  + 7.1G Nov  2 05:07 ProbeSetSE.MYD
  +  11G Aug 27  2019 ProbeData.MYD
  +  63G Dec  4 22:15 ProbeSetData.MYD

(note each is about double that size because of indexes)

ProbeSetSE is done. So ProbeData and ProbeSetData are the main
candidates right now.

Note I set buffers to 16GB for now

```
+innodb_buffer_pool_size=16G
+innodb_ft_min_token_size=3
+# innodb_use_sys_malloc=0
+innodb_file_per_table=ON
```

## Check database

```
time mysqlcheck -c -u webqtlout -pwebqtlout db_webqtl
```

To check one single table Probe

```
root@tux01:/var/lib/mysql/db_webqtl# mysqlcheck -c db_webqtl -u webqtlout -pwebqtlout Probe
db_webqtl.Probe                                    OK
```

Make sure we have not a FULLTEXT column we do not know about (note it needs backquotes around ls):

```
root@tux01:/var/lib/mysql/db_webqtl# for x in ls -1 *.MYD|sed -e 's,\.MYD,,' ; do echo $x ; mysql -u webqtlout -pwebqtlout db_webqtl -e "select group_concat(distinct column_name) from information_schema.STATISTICS where table_schema = 'db_webqtl' and table_name = '$x' and index_type = 'FULLTEXT'" ; done|less
GeneRIF_BASIC
ProbeSet
pubmedsearch
```

still the same.

## Create a test

Start with ProbeSetSE

```
-rw-rw---- 1 mysql mysql 8.1G Dec 28 08:39 ProbeSetSE.MYI
-rw-rw---- 1 mysql mysql 7.1G Nov  2 05:07 ProbeSetSE.MYD
-rw-rw---- 1 mysql mysql 8.5K Feb  3  2021 ProbeSetSE.frm
```

```
MariaDB [db_webqtl]> select * from ProbeSetSE limit 2;
+--------+----------+----------+
| DataId | StrainId | error    |
+--------+----------+----------+
|      1 |        1 | 0.681091 |
|      1 |        2 | 0.361151 |
+--------+----------+----------+
2 rows in set (0.001 sec)

MariaDB [db_webqtl]> select count(*) from ProbeSetSE limit 2;
+-----------+
| count(*)  |
+-----------+
| 688744613 |
+-----------+
1 row in set (0.000 sec)
```

```
MariaDB [db_webqtl]> flush tables ProbeSetSE;
Query OK, 0 rows affected (0.002 sec)
```

```
MariaDB [db_webqtl]> select count(*) from ProbeSetSE where error<0.36;
+-----------+
| count(*)  |
+-----------+
| 601603553 |
+-----------+
1 row in set (1 min 1.189 sec)
```

Some testing shows strainid and error are not indexed. Test query on myisam:

```
MariaDB [db_webqtl]> select count(*) from ProbeSetSE where strainid<20 and error<0.10;
+----------+
| count(*) |
+----------+
| 61625074 |
+----------+
1 row in set (58.301 sec)
```

Check index and primary key (PK):

```
SHOW CREATE TABLE ProbeSetSE;

| ProbeSetSE | CREATE TABLE "ProbeSetSE" (
  "DataId" int(10) unsigned NOT NULL DEFAULT 0,
  "StrainId" smallint(5) unsigned NOT NULL DEFAULT 0,
  "error" float NOT NULL,
  UNIQUE KEY "DataId" ("DataId","StrainId")
) ENGINE=MyISAM DEFAULT CHARSET=latin1 |
```

Note the latin1 we don't need. Also innodb needs a primary key.

The mapping page retrieves SE through a call to

```
retrieve_sample_data(this_trait, dataset)
```

we also have an API endpoint

```
@app.route("/api/v_{}/sample_data/<path:dataset_name>".format(version))
@app.route("/api/v_{}/sample_data/<path:dataset_name>.<path:file_format>".format(version))
def all_sample_data(dataset_name, file_format="csv"):
```

But I can't get it to work for a trait.

```
curl "http://genenetwork.org/api/v_pre1/sample_data/1427571_at"
```

so, instead, I exported the CSV from

=> http://genenetwork.org/show_trait?trait_id=1427571_at&dataset=HC_M2_0606_P

It took the server 2.02924s seconds to process this page.
It took your browser 1.577 second(s) to render this page.

This is our test 'setup'.

## Backup and convert table

On Tux01 the database is hosted on a drive with 111 GB free. Not enough for all conversions. There should be an extra drive in there which requires configuration with reboot. But first we can convert this small table. Backups we have already automated. But I'll add

```
tar cvzf /home/wrk/ProbeSetSE.tgz ProbeSetSE*
```

To convert to InnoDB we should:

* ascertain primary key
* change charset
* change engine to InnoDB
* make space on disk drive(s)

### Set primary key

For ProbeSetSE note the UNIQUE key was already defined. So set a primary key:

```
ALTER TABLE ProbeSetSE
  ADD PRIMARY KEY(DataId,StrainId);
Query OK, 688744613 rows affected (15 min 13.830 sec)
Records: 688744613  Duplicates: 0  Warnings: 0
```

Unsurprisingly the index grew

```
-rw-rw---- 1 mysql mysql  16G Dec 28 11:06 ProbeSetSE.MYI
```

### Change charset

```
MariaDB [db_webqtl]> SHOW CHARACTER SET LIKE 'utf8mb4';
+---------+---------------+--------------------+--------+
| Charset | Description   | Default collation  | Maxlen |
+---------+---------------+--------------------+--------+
| utf8mb4 | UTF-8 Unicode | utf8mb4_general_ci |      4 |
+---------+---------------+--------------------+--------+
1 row in set (0.000 sec)
```

```
MariaDB [db_webqtl]> ALTER TABLE ProbeSetSE CONVERT TO CHARACTER SET utf8mb4 COLLATE utf8mb4_general_ci;
Stage: 2 of 2 'Enabling keys'      0% of stage done
Query OK, 688744613 rows affected (15 min 14.380 sec)
Records: 688744613  Duplicates: 0  Warnings: 0
```

For this table it has no effect since there are not text fields. Still this looks good:

```
SHOW CREATE TABLE ProbeSetSE;
| ProbeSetSE | CREATE TABLE "ProbeSetSE" (
  "DataId" int(10) unsigned NOT NULL DEFAULT 0,
  "StrainId" smallint(5) unsigned NOT NULL DEFAULT 0,
  "error" float NOT NULL,
  PRIMARY KEY ("DataId","StrainId"),
  UNIQUE KEY "DataId" ("DataId","StrainId")
) ENGINE=MyISAM DEFAULT CHARSET=utf8mb4 |
```

Looking good! Now there are two indexes which are the same to

```
MariaDB [db_webqtl]> DROP INDEX DataId ON ProbeSetSE;
```

```
MariaDB [db_webqtl]> show index from ProbeSetSE;
2 rows in set (0.000 sec)
```


### Convert to innodb

So, on to converting to innodb

=> https://mariadb.com/kb/en/converting-tables-from-myisam-to-innodb/

=> https://dataedo.com/kb/query/mysql/list-innodb-tables Show existing innodb tables

Unfortunately we can't swith to 4k page tables because we have existing tables. We'll do that later some day in a controlled fashion.

```
MariaDB [db_webqtl]> ALTER TABLE ProbeSetSE ENGINE = InnoDB;
Query OK, 688744613 rows affected (1 hour 51 min 36.273 sec)
Records: 688744613  Duplicates: 0  Warnings: 0
```

2 hours for a lousy table conversion!

The new file sizes are:

```
-rw-rw---- 1 mysql mysql 1.5K Dec 28 11:33 ProbeSetSE.frm
-rw-rw---- 1 mysql mysql  51G Dec 28 13:25 ProbeSetSE.ibd
```

So the has tripled (including a new index) and during conversion it has both the old and the new on disk. I'll need to make space for this baby.

Let's try OPTIMIZE

```
OPTIMIZE NO_WRITE_TO_BINLOG TABLE ProbeSetSE;
```

Ah, now the size is similar to myisam and loading the mapping page is slighty faster.

## Run tests again

What about performance?

```
MariaDB [db_webqtl]> select count(*) from ProbeSetSE where strainid<20 and error<0.10;
+----------+
| count(*) |
+----------+
| 61625074 |
+----------+
1 row in set (3 min 22.958 sec)
```

Whoah. 3 times slower - which makes sense if you know the physical size of the data. Full table scans should be rare, but we need to make sure we don't slow them down that much!

Again I exported the CSV from

=> http://genenetwork.org/show_trait?trait_id=1427571_at&dataset=HC_M2_0606_P

It took the server 1.46351s seconds to process this page.
It took your browser 2.119 second(s) to render this page

and it shows practically the same results.


## Table template

Prototocol from

=> ./move-to-innodb.gmi

Every table update has to follow the template:

### Check recent backups

* [ ] ascertain there is a backup
* [ ] copy original files

### Make temporary table

If you have enough space, you can create a copy of the actual table and do the work on that:

```
CREATE TABLE new_tbl [AS] SELECT * FROM MYTABLE;
```

Then you can change the column as desired:

```
ALTER TABLE tbl_name MODIFY COLUMN col_name BIGINT AUTO_INCREMENT;
```

Once the process is done, you can rename the tables:

```
DROP MYTABLE;
RENAME TABLE tbl_name TO new_tbl_name, tbl_name2 TO MYTABLE;
```

### Check table structure

```
SHOW CREATE TABLE MYTABLE;
```

```
select * from MYTABLE limit 2;
```

```
select count(*) from MYTABLE;
```

Do this also on Penguin2.

### Check GN1,2,3 code for use of table

```
rg MYTABLE --color=always |less -R
rg MYTABLE --type=py -l|fzf --preview="rg --color=always -A 20 MYTABLE {}" --preview-window=right:85%:wrap
```

### Create test

Some select statement and maybe a page of GN2.

### Create primary key

```
ALTER TABLE MYTABLE
  ADD PRIMARY KEY(col1,col2);
```

### Create indices

```
SHOW INDEX FROM MYTABLE;
DROP INDEX ProbeSetId ON MYTABLE;
```

### Convert to innodb

```
ALTER TABLE MYTABLE ENGINE = InnoDB;
```

### Change charset

```
ALTER TABLE ProbeSetSE CONVERT TO CHARACTER SET utf8mb4 COLLATE utf8mb4_general_ci;
```

### Update fulltext

For those cases see bottom of move-to-innodb.gmi.

### Run optimiser

```
OPTIMIZE NO_WRITE_TO_BINLOG TABLE MYTABLE;
```

After running the optimiser rename the tables

```
RENAME TABLE orig TO orig_old, mytest TO orig;
```

### Check test

## ProbeSetXRef

=> ProbeSetXRef.gmi

## Notes captured from Trello:

In an earlier track I wrote how to deal with Fulltext fields

pjotrp 16 Oct 2019 at 10:47

Fulltext

To list fulltext info for one table do:

```
select group_concat(distinct column_name) from information_schema.STATISTICS where table_schema = 'db_webqtl' and table_name = 'Probeset' and index_type = 'FULLTEXT';
```

Or

```
SHOW CREATE TABLE ProbeSet;

E.g.

  FULLTEXT KEY `SEARCH_GENE_IDX` (`Symbol`,`alias`),
  FULLTEXT KEY `SEARCH_FULL_IDX` (`Name`,`description`,`Symbol`,`alias`,`GenbankId`,`UniGeneId`,`Probe_Target_Description`),
  FULLTEXT KEY `RefSeq_FULL_IDX` (`RefSeq_TranscriptId`)
```

To see all:

```
root@tux02:/var/lib/mysql/db_webqtl# for x in ls -1 *.MYD|sed -e 's,\.MYD,,' ; do echo $x ; mysql -u webqtlout -pwebqtlout db_webqtl -e "select group_concat(distinct column_name) from information_schema.STATISTICS where table_schema = 'db_webqtl' and table_name = '$x' and index_type = 'FULLTEXT'" ; done
```

So we have to fix only

```
ProbeSet
GeneRIF_BASIC
pubmedsearch
```

```
REPAIR TABLE ProbeSet QUICK;
REPAIR TABLE GeneRIF_BASIC QUICK;
REPAIR TABLE pubmedsearch QUICK;
```

Note that GN1 search only appears to use ProbeSet. Reindexing takes
about 10 minutes on Tux02.

After updating to ProbeSet to innodb the following query failed


```
SELECT distinct ProbeSet.Name as TNAME, 0 as thistable, ProbeSetXRef.Mean as TMEAN, ProbeSetXRef.LRS as TLRS, ProbeSetXRef.PVALUE as TPVALUE, ProbeSet.Chr_num as TCHR_NUM, ProbeSet.Mb as TMB, ProbeSet.Symbol as TSYMBOL, ProbeSet.name_num as TNAME_NUM FROM ProbeSetXRef, ProbeSet WHERE ((MATCH (ProbeSet.Name, ProbeSet.description, ProbeSet.symbol, alias, GenbankId, UniGeneId, Probe_Target_Description) AGAINST ('shh' IN BOOLEAN MODE)) or (MATCH (ProbeSet.symbol) AGAINST ('"Hx" "ShhNC" "9530036O11Rik" "Dsh" "Hhg1" "Hxl3" "M100081"' IN BOOLEAN MODE))) and ProbeSet.Id = ProbeSetXRef.ProbeSetId and ProbeSetXRef.ProbeSetFreezeId = 112 ORDER BY ProbeSet.symbol ASC;
```

with

```
ERROR 1191 (HY000): Can't find FULLTEXT index matching the column list
```

The shorter version works

```
SELECT distinct ProbeSet.Name as TNAME, 0 as thistable, ProbeSetXRef.Mean as TMEAN, ProbeSetXRef.LRS as TLRS, ProbeSetXRef.PVALUE as TPVALUE, ProbeSet.Chr_num as TCHR_NUM, ProbeSet.Mb as TMB, ProbeSet.Symbol as TSYMBOL, ProbeSet.name_num as TNAME_NUM FROM ProbeSetXRef, ProbeSet WHERE ((MATCH (ProbeSet.Name, ProbeSet.description, ProbeSet.symbol, alias, GenbankId, UniGeneId, Probe_Target_Description) AGAINST ('"Shh" "ShhNC" "9530036O11Rik" "Dsh" "Hhg1"' IN BOOLEAN MODE))) and ProbeSet.Id = ProbeSetXRef.ProbeSetId and ProbeSetXRef.ProbeSetFreezeId = 112;
```

when you remove any column in the MATCH statement we get this
error. Which kinda makes sense I suppose. We need to add an index
for the single ProbeSet.symbol match. Create it with

```
CREATE FULLTEXT INDEX ft_ProbeSet_Symbol ON ProbeSet(Symbol);
```

Now we have

```
FULLTEXT KEY `SEARCH_GENE_IDX` (`Symbol`,`alias`),
FULLTEXT KEY `SEARCH_FULL_IDX` (`Name`,`description`,`Symbol`,`alias`,`GenbankId`,`UniGeneId`,`Probe_Target_Description`),
FULLTEXT KEY `RefSeq_FULL_IDX` (`RefSeq_TranscriptId`),
FULLTEXT KEY `ft_ProbeSet_Symbol` (`Symbol`)
```

and the query works.

pjotrp 16 Oct 2019 at 09:24 (edited)

Full text search is the least straightforward, see

and

Now for ProbeSet - one of the critical locked tables we need this.

pjotrp 15 Oct 2019 at 16:38 (edited)

```
time mysqlcheck -c -u webqtlout -pwebqtlout db_webqtl
db_webqtl.Docs
warning : 1 client is using or hasn't closed the table properly
status : OK

real 16m52.567s
```

## Convert to InnoDB

The largest tables are

```
1.6G Aug 27  2019 Probe.MYD
2.1G Aug 27  2019 LCorrRamin3.MYD
2.1G Dec  4 22:15 ProbeSetXRef.MYD
2.3G Dec 18 14:56 ProbeSet.MYD
2.6G Aug 27  2019 ProbeSE.MYD
7.1G Nov  2 05:07 ProbeSetSE.MYD
8.3G Aug 28  2019 SnpPattern.MYD
 11G Aug 27  2019 ProbeData.MYD
 11G May 22  2020 GenoData.MYD
 11G Aug 27  2019 SnpAll.MYD
 63G Dec  4 22:15 ProbeSetData.MYD
```

On Penguin2 we are already runing ProbeSetData as

```
238G Jul 10  2020 ProbeSetData.ibd
```

which is pretty massive! It includes the index, which is 180G, so the difference is not that great. Also we should try a 4kb page size. Also make sure to enable innodb_file_per_table.

## Updating tux01

With a recent update the following tables appeared to lock up:
ProbeSet, ProbeSetFreeze, ProbeSetXRef. All of them small, so let's move them to innodb.

```
select count(*) from ProbeSetFreeze limit 2;
+----------+
| count(*) |
+----------+
|      931 |
+----------+
SHOW CREATE TABLE ProbeSetFreeze;
CREATE TABLE `ProbeSetFreeze` (
  `Id` smallint(5) unsigned NOT NULL AUTO_INCREMENT,
  `ProbeFreezeId` smallint(5) unsigned NOT NULL DEFAULT 0,
  `AvgID` smallint(5) unsigned NOT NULL DEFAULT 0,
  `Name` varchar(40) DEFAULT NULL,
  `Name2` varchar(100) NOT NULL DEFAULT '',
  `FullName` varchar(100) NOT NULL DEFAULT '',
  `ShortName` varchar(100) NOT NULL DEFAULT '',
  `CreateTime` date NOT NULL DEFAULT '0000-00-00',
  `OrderList` int(5) DEFAULT NULL,
  `public` tinyint(4) NOT NULL DEFAULT 0,
  `confidentiality` tinyint(4) NOT NULL DEFAULT 0,
  `AuthorisedUsers` varchar(300) NOT NULL,
  `DataScale` varchar(20) NOT NULL DEFAULT 'log2',
  PRIMARY KEY (`Id`),
  UNIQUE KEY `FullName` (`FullName`),
  UNIQUE KEY `Name` (`Name`),
  KEY `NameIndex` (`Name2`)
) ENGINE=MyISAM AUTO_INCREMENT=1054 DEFAULT CHARSET=latin1
```

There is a primary key. Good.

ALTER TABLE ProbeSetSE
  ADD PRIMARY KEY(DataId,StrainId);
Query OK, 688744613 rows affected (15 min 13.830 sec)
Records: 688744613  Duplicates: 0  Warnings: 0
```

Unsurprisingly the index grew

```
-rw-rw---- 1 mysql mysql  16G Dec 28 11:06 ProbeSetSE.MYI
```

### Change charset

```
MariaDB [db_webqtl]> SHOW CHARACTER SET LIKE 'utf8mb4';
+---------+---------------+--------------------+--------+
| Charset | Description   | Default collation  | Maxlen |
+---------+---------------+--------------------+--------+
| utf8mb4 | UTF-8 Unicode | utf8mb4_general_ci |      4 |
+---------+---------------+--------------------+--------+
1 row in set (0.000 sec)
```

```
MariaDB [db_webqtl]> ALTER TABLE ProbeSetSE CONVERT TO CHARACTER SET utf8mb4 COLLATE utf8mb4_general_ci;
Stage: 2 of 2 'Enabling keys'      0% of stage done
Query OK, 688744613 rows affected (15 min 14.380 sec)
Records: 688744613  Duplicates: 0  Warnings: 0
```

For this table it has no effect since there are not text fields. Still this looks good:

```
SHOW CREATE TABLE ProbeSetSE;
| ProbeSetSE | CREATE TABLE "ProbeSetSE" (
  "DataId" int(10) unsigned NOT NULL DEFAULT 0,
  "StrainId" smallint(5) unsigned NOT NULL DEFAULT 0,
  "error" float NOT NULL,
  PRIMARY KEY ("DataId","StrainId"),
  UNIQUE KEY "DataId" ("DataId","StrainId")
) ENGINE=MyISAM DEFAULT CHARSET=utf8mb4 |
```

Looking good! Now there are two indexes which are the same to

```
MariaDB [db_webqtl]> DROP INDEX DataId ON ProbeSetSE;
```

```
MariaDB [db_webqtl]> show index from ProbeSetSE;
2 rows in set (0.000 sec)
```


### Convert to innodb

So, on to converting to innodb

=> https://mariadb.com/kb/en/converting-tables-from-myisam-to-innodb/

=> https://dataedo.com/kb/query/mysql/list-innodb-tables Show existing innodb tables

Unfortunately we can't swith to 4k page tables because we have existing tables. We'll do that later some day in a controlled fashion.

```
MariaDB [db_webqtl]> ALTER TABLE ProbeSetSE ENGINE = InnoDB;
Query OK, 688744613 rows affected (1 hour 51 min 36.273 sec)
Records: 688744613  Duplicates: 0  Warnings: 0
```

2 hours for a lousy table conversion!

The new file sizes are:

```
-rw-rw---- 1 mysql mysql 1.5K Dec 28 11:33 ProbeSetSE.frm
-rw-rw---- 1 mysql mysql  51G Dec 28 13:25 ProbeSetSE.ibd
```

So the has tripled (including a new index) and during conversion it has both the old and the new on disk. I'll need to make space for this baby.

Let's try OPTIMIZE

```
OPTIMIZE NO_WRITE_TO_BINLOG TABLE ProbeSetSE;
```

Ah, now the size is similar to myisam and loading the mapping page is slighty faster.

## Run tests again

What about performance?

```
MariaDB [db_webqtl]> select count(*) from ProbeSetSE where strainid<20 and error<0.10;
+----------+
| count(*) |
+----------+
| 61625074 |
+----------+
1 row in set (3 min 22.958 sec)
```

Whoah. 3 times slower - which makes sense if you know the physical size of the data. Full table scans should be rare, but we need to make sure we don't slow them down that much!

Again I exported the CSV from

=> http://genenetwork.org/show_trait?trait_id=1427571_at&dataset=HC_M2_0606_P

It took the server 1.46351s seconds to process this page.
It took your browser 2.119 second(s) to render this page

and it shows practically the same results.


## Table template

Prototocol from

=> ./move-to-innodb.gmi

Every table update has to follow the template:

### Check recent backups

* [ ] ascertain there is a backup
* [ ] copy original files

### Make temporary table

If you have enough space, you can create a copy of the actual table and do the work on that:

```
CREATE TABLE new_tbl [AS] SELECT * FROM MYTABLE;
```

Then you can change the column as desired:

```
ALTER TABLE tbl_name MODIFY COLUMN col_name BIGINT AUTO_INCREMENT;
```

Once the process is done, you can rename the tables:

```
DROP MYTABLE;
RENAME TABLE tbl_name TO new_tbl_name, tbl_name2 TO MYTABLE;
```

### Check table structure

```
SHOW CREATE TABLE MYTABLE;
```

```
select * from MYTABLE limit 2;
```

```
select count(*) from MYTABLE;
```

Do this also on Penguin2.

### Check GN1,2,3 code for use of table

```
rg MYTABLE --color=always |less -R
rg MYTABLE --type=py -l|fzf --preview="rg --color=always -A 20 MYTABLE {}" --preview-window=right:85%:wrap
```

### Create test

Some select statement and maybe a page of GN2.

### Create primary key

```
ALTER TABLE MYTABLE
  ADD PRIMARY KEY(col1,col2);
```

### Create indices

```
SHOW INDEX FROM MYTABLE;
DROP INDEX ProbeSetId ON MYTABLE;
```

### Convert to innodb

```
ALTER TABLE MYTABLE ENGINE = InnoDB;
```

### Change charset

```
ALTER TABLE ProbeSetSE CONVERT TO CHARACTER SET utf8mb4 COLLATE utf8mb4_general_ci;
```

### Update fulltext

For those cases see bottom of move-to-innodb.gmi.

### Run optimiser

```
OPTIMIZE NO_WRITE_TO_BINLOG TABLE MYTABLE;
```

After running the optimiser rename the tables

```
RENAME TABLE orig TO orig_old, mytest TO orig;
```

### Check test

## ProbeSetXRef

=> ProbeSetXRef.gmi

## Notes captured from Trello:

In an earlier track I wrote how to deal with Fulltext fields

pjotrp 16 Oct 2019 at 10:47

Fulltext

To list fulltext info for one table do:

```
select group_concat(distinct column_name) from information_schema.STATISTICS where table_schema = 'db_webqtl' and table_name = 'Probeset' and index_type = 'FULLTEXT';
```

Or

```
SHOW CREATE TABLE ProbeSet;

E.g.

  FULLTEXT KEY `SEARCH_GENE_IDX` (`Symbol`,`alias`),
  FULLTEXT KEY `SEARCH_FULL_IDX` (`Name`,`description`,`Symbol`,`alias`,`GenbankId`,`UniGeneId`,`Probe_Target_Description`),
  FULLTEXT KEY `RefSeq_FULL_IDX` (`RefSeq_TranscriptId`)
```

To see all:

```
root@tux02:/var/lib/mysql/db_webqtl# for x in ls -1 *.MYD|sed -e 's,\.MYD,,' ; do echo $x ; mysql -u webqtlout -pwebqtlout db_webqtl -e "select group_concat(distinct column_name) from information_schema.STATISTICS where table_schema = 'db_webqtl' and table_name = '$x' and index_type = 'FULLTEXT'" ; done
```

So we have to fix only

```
ProbeSet
GeneRIF_BASIC
pubmedsearch
```

```
REPAIR TABLE ProbeSet QUICK;
REPAIR TABLE GeneRIF_BASIC QUICK;
REPAIR TABLE pubmedsearch QUICK;
```

Note that GN1 search only appears to use ProbeSet. Reindexing takes
about 10 minutes on Tux02.

After updating to ProbeSet to innodb the following query failed


```
SELECT distinct ProbeSet.Name as TNAME, 0 as thistable, ProbeSetXRef.Mean as TMEAN, ProbeSetXRef.LRS as TLRS, ProbeSetXRef.PVALUE as TPVALUE, ProbeSet.Chr_num as TCHR_NUM, ProbeSet.Mb as TMB, ProbeSet.Symbol as TSYMBOL, ProbeSet.name_num as TNAME_NUM FROM ProbeSetXRef, ProbeSet WHERE ((MATCH (ProbeSet.Name, ProbeSet.description, ProbeSet.symbol, alias, GenbankId, UniGeneId, Probe_Target_Description) AGAINST ('shh' IN BOOLEAN MODE)) or (MATCH (ProbeSet.symbol) AGAINST ('"Hx" "ShhNC" "9530036O11Rik" "Dsh" "Hhg1" "Hxl3" "M100081"' IN BOOLEAN MODE))) and ProbeSet.Id = ProbeSetXRef.ProbeSetId and ProbeSetXRef.ProbeSetFreezeId = 112 ORDER BY ProbeSet.symbol ASC;
```

with

```
ERROR 1191 (HY000): Can't find FULLTEXT index matching the column list
```

The shorter version works

```
SELECT distinct ProbeSet.Name as TNAME, 0 as thistable, ProbeSetXRef.Mean as TMEAN, ProbeSetXRef.LRS as TLRS, ProbeSetXRef.PVALUE as TPVALUE, ProbeSet.Chr_num as TCHR_NUM, ProbeSet.Mb as TMB, ProbeSet.Symbol as TSYMBOL, ProbeSet.name_num as TNAME_NUM FROM ProbeSetXRef, ProbeSet WHERE ((MATCH (ProbeSet.Name, ProbeSet.description, ProbeSet.symbol, alias, GenbankId, UniGeneId, Probe_Target_Description) AGAINST ('"Shh" "ShhNC" "9530036O11Rik" "Dsh" "Hhg1"' IN BOOLEAN MODE))) and ProbeSet.Id = ProbeSetXRef.ProbeSetId and ProbeSetXRef.ProbeSetFreezeId = 112;
```

when you remove any column in the MATCH statement we get this
error. Which kinda makes sense I suppose. We need to add an index
for the single ProbeSet.symbol match. Create it with

```
CREATE FULLTEXT INDEX ft_ProbeSet_Symbol ON ProbeSet(Symbol);
```

Now we have

```
FULLTEXT KEY `SEARCH_GENE_IDX` (`Symbol`,`alias`),
FULLTEXT KEY `SEARCH_FULL_IDX` (`Name`,`description`,`Symbol`,`alias`,`GenbankId`,`UniGeneId`,`Probe_Target_Description`),
FULLTEXT KEY `RefSeq_FULL_IDX` (`RefSeq_TranscriptId`),
FULLTEXT KEY `ft_ProbeSet_Symbol` (`Symbol`)
```

and the query works.

pjotrp 16 Oct 2019 at 09:24 (edited)

Full text search is the least straightforward, see

and

Now for ProbeSet - one of the critical locked tables we need this.

pjotrp 15 Oct 2019 at 16:38 (edited)

```
time mysqlcheck -c -u webqtlout -pwebqtlout db_webqtl
db_webqtl.Docs
warning : 1 client is using or hasn't closed the table properly
status : OK

real 16m52.567s
```

## Convert to InnoDB

The largest tables are

```
1.6G Aug 27  2019 Probe.MYD
2.1G Aug 27  2019 LCorrRamin3.MYD
2.1G Dec  4 22:15 ProbeSetXRef.MYD
2.3G Dec 18 14:56 ProbeSet.MYD
2.6G Aug 27  2019 ProbeSE.MYD
7.1G Nov  2 05:07 ProbeSetSE.MYD
8.3G Aug 28  2019 SnpPattern.MYD
 11G Aug 27  2019 ProbeData.MYD
 11G May 22  2020 GenoData.MYD
 11G Aug 27  2019 SnpAll.MYD
 63G Dec  4 22:15 ProbeSetData.MYD
```

On Penguin2 we are already runing ProbeSetData as

```
238G Jul 10  2020 ProbeSetData.ibd
```

which is pretty massive! It includes the index, which is 180G, so the difference is not that great. Also we should try a 4kb page size. Also make sure to enable innodb_file_per_table.

## Updating tux01

With a recent update the following tables appeared to lock up:
ProbeSet, ProbeSetFreeze, ProbeSetXRef. All of them small, so let's move them to innodb.

```
select count(*) from ProbeSetFreeze limit 2;
+----------+
| count(*) |
+----------+
|      931 |
+----------+
SHOW CREATE TABLE ProbeSetFreeze;
CREATE TABLE `ProbeSetFreeze` (
  `Id` smallint(5) unsigned NOT NULL AUTO_INCREMENT,
  `ProbeFreezeId` smallint(5) unsigned NOT NULL DEFAULT 0,
  `AvgID` smallint(5) unsigned NOT NULL DEFAULT 0,
  `Name` varchar(40) DEFAULT NULL,
  `Name2` varchar(100) NOT NULL DEFAULT '',
  `FullName` varchar(100) NOT NULL DEFAULT '',
  `ShortName` varchar(100) NOT NULL DEFAULT '',
  `CreateTime` date NOT NULL DEFAULT '0000-00-00',
  `OrderList` int(5) DEFAULT NULL,
  `public` tinyint(4) NOT NULL DEFAULT 0,
  `confidentiality` tinyint(4) NOT NULL DEFAULT 0,
  `AuthorisedUsers` varchar(300) NOT NULL,
  `DataScale` varchar(20) NOT NULL DEFAULT 'log2',
  PRIMARY KEY (`Id`),
  UNIQUE KEY `FullName` (`FullName`),
  UNIQUE KEY `Name` (`Name`),
  KEY `NameIndex` (`Name2`)
) ENGINE=MyISAM AUTO_INCREMENT=1054 DEFAULT CHARSET=latin1
```

There is a primary key. Good. You might want to check

```
mysql -uwebqtlout -pwebqtlout db_webqtl
SHOW FULL PROCESSLIST;
flush tables;
ALTER TABLE ProbeSetFreeze CONVERT TO CHARACTER SET utf8mb4 COLLATE utf8mb4_general_ci;
```

This makes GN a bit snappier, it appears. Next to fix is the AccessLog because Gn1 writes to it.

So:

```
show create table TempData;
ALTER TABLE TempData CONVERT TO CHARACTER SET utf8mb4 COLLATE utf8mb4_general_ci;
ALTER TABLE TempData ENGINE = InnoDB;
alter table TempData add primary key (Id);
show create table TempData;
```

## Tags

* assigned: pjotr
* type: enhancement, documentation
* status: unclear
* priority: medium
* keywords: database, mariadb, innodb