blob: 8a05323eb5b87795261819926c4642de2fbaf07d (
about) (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
|
# Cleanup GN2 Base HTML File
## Tags
* Assigned: alexm
* Keywords: base, HTML, JavaScript, cleanup
* type: Refactoring
* Status: closed, completed, done
## Description
The base file should contain no custom JavaScript since it is inherited in almost all files in GN2. It should only include what is necessary. As a result, we need to move the global search from the base file to the index page, which renders the GN2 home.
## Tasks
* [x] Remove global search code from the base file and move it to the index page
* [x] Fix formatting and linting issues in the base file (e.g., tags)
* [x] Inherit from index page for all gn2 templates
## Notes
See the PR that seeks to fix this:
=> https://github.com/genenetwork/genenetwork2/pull/877
## Notes 26/09/2024
It was agreed that global search should be a feature for all pages,
As such all files need to inherit from the global search which
defines the global search.
|
