blob: cc5d6db02886a181381a5573f08cbb4a5f43fefb (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
|
# Temp traits don't seem to be handled by the authorization system
## Tags
* assigned: fredm, zsloan
* priority: high
* status: closed, completed
* keywords: authentication, authorisation, oauth2, temp-traits, gn-auth
* type: bug
## Description
Trying to view the trait page for a temp trait (such as the PCA traits generated from the correlation matrix page) throws an error. I think this is because the authorization endpoint doesn't account for temp traits.
Not sure how to handle this, since the trait page code currently expects privileges information. The authorization code in question probably needs to be changed (it should probably just assume all temp traits are public).
## How to reproduce
Add some traits to a collection (or just select some from search results), run "Correlations," and click one of the traits in the PCA Traits table.
## Fixes
=> https://github.com/genenetwork/genenetwork3/commit/1bd01c7396daf9413e9524d7e627e9e36b281213
This commit adds a patch to make **ALL** "Temp" traits publicly readable. This is necessary since the "Temp" traits are not attached to any resources. It is also because unlike all the other traits, "Temp" traits are not saved in the database, rather, they are saved in redis which might make them ephemeral.
|
