summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
-rw-r--r--issues/sample-data-not-appearing-in-phenotype-editing-page.gmi4
-rw-r--r--topics/editing/phenotypes.gmi4
2 files changed, 7 insertions, 1 deletions
diff --git a/issues/sample-data-not-appearing-in-phenotype-editing-page.gmi b/issues/sample-data-not-appearing-in-phenotype-editing-page.gmi
index b96841f..99536d2 100644
--- a/issues/sample-data-not-appearing-in-phenotype-editing-page.gmi
+++ b/issues/sample-data-not-appearing-in-phenotype-editing-page.gmi
@@ -6,7 +6,7 @@
* priority: urgent
* type: bug
* keywords: editing, phenotype, phenotype editing
-* status: open
+* status: closed
## Description
@@ -16,3 +16,5 @@ On clicking the "Edit" button in the traits' page (/show_trait?...), the sample
=> https://github.com/genenetwork/genenetwork2/blob/f8263ccb64daa5cbeeb0b1d7da3605f825e8acb6/wqflask/wqflask/metadata_edits.py#L132 Line 132 of metadata_edits.py module
gives back an empty `sample_list`
+
+The code was fetching the configurations from the environment, which is not always set. Change the code to fetch configurations from the application object.
diff --git a/topics/editing/phenotypes.gmi b/topics/editing/phenotypes.gmi
index dfb33d1..68e278d 100644
--- a/topics/editing/phenotypes.gmi
+++ b/topics/editing/phenotypes.gmi
@@ -32,3 +32,7 @@ There is old code for editing phenotypes in place, but it was not in use. The ma
- [X] Update to new auth system for approving diffs
- [X] Update to new auth system for approving diffs
- [ ] Figure out why sample data is not showing up on edit page
+
+## Issues
+
+=> issues/sample-data-not-appearing-in-phenotype-editing-page.gmi