summaryrefslogtreecommitdiff
path: root/issues
diff options
context:
space:
mode:
authorzsloan2023-12-12 16:08:18 -0600
committerGitHub2023-12-12 16:08:18 -0600
commitc2866ebe9a1584adc50ad8a617462cc314ca0683 (patch)
treecfc2b8297bb4db4ffa8ccc43c41d9ab3e686b273 /issues
parenta796078b1358b798eabba191ca9dff9ec775c07a (diff)
downloadgn-gemtext-c2866ebe9a1584adc50ad8a617462cc314ca0683.tar.gz
Create import_collections_popup_bug.gmi
Diffstat (limited to 'issues')
-rw-r--r--issues/import_collections_popup_bug.gmi23
1 files changed, 23 insertions, 0 deletions
diff --git a/issues/import_collections_popup_bug.gmi b/issues/import_collections_popup_bug.gmi
new file mode 100644
index 0000000..8fda79b
--- /dev/null
+++ b/issues/import_collections_popup_bug.gmi
@@ -0,0 +1,23 @@
+# Import Collections Pop-up Bug
+
+## Tags
+
+* assigned: fredm, zachs
+* priority: urgent
+* type: bug
+* status: open
+* keywords: collections
+
+## Description
+
+If you create collections while logged-out, log in, and import them, the notification asking if you want to import or delete will remain visible on the home page until you either log out or choose to delete instead.
+
+To reproduce:
+* Create a collection (just do a search like the following, select all, add to collection - https://genenetwork.org/search?species=mouse&group=BXD&type=Hippocampus+mRNA&dataset=HC_M2_0606_P&search_terms_or=shh&search_terms_and=&FormID=searchResult )
+* Log in
+* Choose "Import" in the "pop-up" and click Submit
+* The home/index page will continue to show the option to import/delete indefinitely
+
+The reason for this seems pretty clear after looking at the code. There's something in the index page template that checks if anon_collections > 0, and it shows the pop-up if it is. So importing collections naturally doesn't get rid of this, since anon_collections still exist (which is desirable, since they should still be accessible if the user logs out).
+
+I'm not sure how to deal with this. The only thing I can think of is having some sort of flag indicating "collections have already been imported," but I'm not sure where to put that flag. And ideally it also needs to detect if there's any overlap between existing collections and the anon_collections (I'm not sure if it does this currently).