diff options
| author | Frederick Muriuki Muriithi | 2024-02-27 05:07:41 +0300 |
|---|---|---|
| committer | Frederick Muriuki Muriithi | 2024-02-27 05:07:41 +0300 |
| commit | f77b169c09be92014dcfea49d427268381fe12e5 (patch) | |
| tree | 6a73659cb645b13c1ac409dcb7b124ba0165b69a /issues/quality-control | |
| parent | 15930e2d90894026083a8b21d2fef88562188a7a (diff) | |
| download | gn-gemtext-f77b169c09be92014dcfea49d427268381fe12e5.tar.gz | |
Update issues, closing some that are complete.
Diffstat (limited to 'issues/quality-control')
| -rw-r--r-- | issues/quality-control/Fix-opaque-errors.gmi | 4 | ||||
| -rw-r--r-- | issues/quality-control/qc-fix-integration-tests.gmi | 10 | ||||
| -rw-r--r-- | issues/quality-control/read-samples-from-database-by-species.gmi | 6 |
3 files changed, 12 insertions, 8 deletions
diff --git a/issues/quality-control/Fix-opaque-errors.gmi b/issues/quality-control/Fix-opaque-errors.gmi index 0f81233..3864c81 100644 --- a/issues/quality-control/Fix-opaque-errors.gmi +++ b/issues/quality-control/Fix-opaque-errors.gmi @@ -2,11 +2,11 @@ ## Tags -* status: open +* status: closed, completed * assigned: fredm * type: bug * priority: high -* keywords: opaque errors, errors, UX, user experience +* keywords: opaque errors, errors, UX, user experience, gn-uploader ## Description diff --git a/issues/quality-control/qc-fix-integration-tests.gmi b/issues/quality-control/qc-fix-integration-tests.gmi index cf0b833..c233c20 100644 --- a/issues/quality-control/qc-fix-integration-tests.gmi +++ b/issues/quality-control/qc-fix-integration-tests.gmi @@ -4,8 +4,8 @@ * assigned: fredm * priority: medium -* status: open -* keywords: quality control, qc, tests +* status: closed, completed +* keywords: quality control, qc, tests, gn-uploader * type: bug ## Description @@ -19,3 +19,9 @@ command = [shutil.which("redis-server"), "--port", str(port)] This is because the `shutil.which("redis-server")` call returns `None` in the newer code, due to removal of redis (the server) from the list of dependencies. To work around the issue, I suggest the use of an explicit, albeit temporary, redis database for testing, by modifying the `REDIS_URL` value in the tests sessions. The modification will simply change the URL to point to a new database for the test session, enabling the tests to run unhindered, but also without tainting the production redis databases. + +### Update 2024-02-27 + +The system was updated to use prefixed keys, and the full tests now run correctly. + +=> /issues/gn-uploader/rework-tests-remove-redis-as-test-dependency related issue diff --git a/issues/quality-control/read-samples-from-database-by-species.gmi b/issues/quality-control/read-samples-from-database-by-species.gmi index fae1a18..fa66c17 100644 --- a/issues/quality-control/read-samples-from-database-by-species.gmi +++ b/issues/quality-control/read-samples-from-database-by-species.gmi @@ -5,8 +5,8 @@ * type: bug * priority: critical * assigned: fredm, acenteno -* keywords: QC, quality control, samples, strains, cases -* status: open +* keywords: QC, quality control, samples, strains, cases, gn-uploader +* status: closed, completed ## Description @@ -30,5 +30,3 @@ This was a myopic view of the data uploader, and needs to be expanded significan Fixed with this commit: => https://gitlab.com/fredmanglis/gnqc_py/-/commit/cdd4dc456e56bb4eb055e1cb7f2518d45fb3bfb9 - -Awaiting deployment |