diff options
| author | Frederick Muriuki Muriithi | 2022-10-24 03:19:11 +0300 |
|---|---|---|
| committer | Frederick Muriuki Muriithi | 2022-10-24 03:19:11 +0300 |
| commit | 77e7ea7b7fb9fd2961526122a41512fd00da9858 (patch) | |
| tree | 36b27eee02b9e8650fb0a65caca0a608b3790b02 /issues/decouple-tasks-in-results-display.gmi | |
| parent | 07d5160ad1d20cea26861cbab85f7f5230414c88 (diff) | |
| download | gn-gemtext-77e7ea7b7fb9fd2961526122a41512fd00da9858.tar.gz | |
Issues (decouple-tasks-in-results-display): New issue
* issues/decouple-tasks-in-results-display.gmi: add a new issue.
Diffstat (limited to 'issues/decouple-tasks-in-results-display.gmi')
| -rw-r--r-- | issues/decouple-tasks-in-results-display.gmi | 13 |
1 files changed, 13 insertions, 0 deletions
diff --git a/issues/decouple-tasks-in-results-display.gmi b/issues/decouple-tasks-in-results-display.gmi new file mode 100644 index 0000000..41fa057 --- /dev/null +++ b/issues/decouple-tasks-in-results-display.gmi @@ -0,0 +1,13 @@ +# Decouple Tasks in Correlations Results Display + +## Tags + +## Description + +=> https://github.com/genenetwork/genenetwork2/blob/f03127d751cd629596c2595d700fbb044725e01c/wqflask/wqflask/correlation/show_corr_results.py#L112 The loop processing the results +is doing way too much. + +We need to slowly decouple the different tasks into separate functions that can be called successively on each individual trait to build up the results, with something like the `map` function, or list comprehensions. + +=> https://github.com/genenetwork/genenetwork2/blob/f03127d751cd629596c2595d700fbb044725e01c/wqflask/wqflask/correlation/show_corr_results.py#L116-L122 The conditional fetching of traits data +should probably be done before we enter the looping part of the results processing to make the logic easier and decouple the fetching from the results processing. |