summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorFrederick Muriuki Muriithi2022-11-25 07:34:42 +0300
committerFrederick Muriuki Muriithi2022-11-25 07:35:40 +0300
commitdd0644c5a96d530c930cd5ff43c3cead7d8a87b7 (patch)
tree59a9b4605764c73cf0cf62517d9233c0b241e656
parent98df654b163d062deab4cbe7ed4a898ab6aaf426 (diff)
downloadgn-gemtext-dd0644c5a96d530c930cd5ff43c3cead7d8a87b7.tar.gz
issues: decouple-tasks-in-results-display: Add note on bulk querying
* issues/decouple-tasks-in-results-display.gmi: Add notes on bulk querying of the metadata.
-rw-r--r--issues/decouple-tasks-in-results-display.gmi11
1 files changed, 11 insertions, 0 deletions
diff --git a/issues/decouple-tasks-in-results-display.gmi b/issues/decouple-tasks-in-results-display.gmi
index af4ee1c..ab1ccd5 100644
--- a/issues/decouple-tasks-in-results-display.gmi
+++ b/issues/decouple-tasks-in-results-display.gmi
@@ -25,3 +25,14 @@ should probably be done before we enter the looping part of the results processi
pr to fix this issue
=> https://github.com/genenetwork/genenetwork2/pull/742
+
+## 2022-11-25
+
+### Bulk Querying
+
+The code in the
+=> https://github.com/genenetwork/genenetwork2/blob/d318b1d649a3ece1a5a6c24bcd3496e14dbc69cd/wqflask/wqflask/correlation/show_corr_results.py#L169-L179 `generate_table_metadata` function
+is still fetching the data one trait at a time, which is a performance bottleneck.
+
+This could be changed to operate
+=> https://github.com/genenetwork/genenetwork3/blob/4a9fd93d01b6d4bd9d9880dbf2274b3c7f2de37b/gn3/db/partial_correlations.py#L751-L791 something like this