summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorFrederick Muriuki Muriithi2023-10-09 07:15:45 +0300
committerFrederick Muriuki Muriithi2023-10-09 07:15:45 +0300
commitd0ed9e7eb7f4d6eba4ec9ed3dcc8acc1b3c515f7 (patch)
treecc9cab70eb06c9526d3b36518cffb73f0fd0fa99
parent89afa440856c92e3bb0b57936a40e50da65df5f1 (diff)
downloadgn-gemtext-d0ed9e7eb7f4d6eba4ec9ed3dcc8acc1b3c515f7.tar.gz
Update issue with fixes.
-rw-r--r--issues/add-to-collection-error.gmi6
1 files changed, 6 insertions, 0 deletions
diff --git a/issues/add-to-collection-error.gmi b/issues/add-to-collection-error.gmi
index 09de0ae..5b4a901 100644
--- a/issues/add-to-collection-error.gmi
+++ b/issues/add-to-collection-error.gmi
@@ -55,3 +55,9 @@ Some files that are concerned with the issue:
Probable solution: add `method="POST"` to the "<form ...>" line in the "add.html" file, but there is a chance that might break other features that depend on the same form. This will need to be done carefully.
In retrospect, this feature should not use "GET" at all, since it is not indempotent. Every run has the potential to change the state of the underlying collection(s). All features depending on the "add.html" template should use the "POST" method, never "GET".
+
+## Fixes
+
+=> https://github.com/genenetwork/genenetwork2/commit/1915fcdf7f67cd76348b06070e86aedfb4076f01
+
+This converts the requests to use the POST method which does not have any data size limits according to the HTTP protocol (in practice, there is probably a limit, but that is a configuration value, and we are unlikely to hit it).