diff options
| author | Frederick Muriuki Muriithi | 2024-01-09 02:24:23 +0300 |
|---|---|---|
| committer | Frederick Muriuki Muriithi | 2024-01-09 02:24:23 +0300 |
| commit | 7cdd2cb8de42fe4481fc152400a54e010a7a3ab1 (patch) | |
| tree | df4305e11d7b8c0553fed00abfbb059fe58947a0 | |
| parent | 6a2ed4ea3c18382627285f0fc782d22d5269eee2 (diff) | |
| download | gn-gemtext-7cdd2cb8de42fe4481fc152400a54e010a7a3ab1.tar.gz | |
QC: New Issue.
| -rw-r--r-- | issues/quality-control/qc-fix-integration-tests.gmi | 21 |
1 files changed, 21 insertions, 0 deletions
diff --git a/issues/quality-control/qc-fix-integration-tests.gmi b/issues/quality-control/qc-fix-integration-tests.gmi new file mode 100644 index 0000000..cf0b833 --- /dev/null +++ b/issues/quality-control/qc-fix-integration-tests.gmi @@ -0,0 +1,21 @@ +# QC: Fix Integration Tests + +## Tags + +* assigned: fredm +* priority: medium +* status: open +* keywords: quality control, qc, tests +* type: bug + +## Description + +Tests that require that Redis be present in order to run, fail due to the statement +``` +command = [shutil.which("redis-server"), "--port", str(port)] +``` +=> https://gitlab.com/fredmanglis/gnqc_py/-/blob/6200a60eb6f04a5d50bfe0ad366674dc49a08119/tests/conftest.py#L32 in "tests/conftest.py". + +This is because the `shutil.which("redis-server")` call returns `None` in the newer code, due to removal of redis (the server) from the list of dependencies. + +To work around the issue, I suggest the use of an explicit, albeit temporary, redis database for testing, by modifying the `REDIS_URL` value in the tests sessions. The modification will simply change the URL to point to a new database for the test session, enabling the tests to run unhindered, but also without tainting the production redis databases. |