diff options
author | Frederick Muriuki Muriithi | 2023-12-18 16:04:21 +0300 |
---|---|---|
committer | Frederick Muriuki Muriithi | 2023-12-18 16:04:21 +0300 |
commit | 7a83f48ed8576503d7389568f3844d12ab397060 (patch) | |
tree | 7ae46ec6d3140c8074f8633c2b370c94c01e95a2 | |
parent | 2f28e004e6db1b754108506eccdd17dbc19a8d8c (diff) | |
download | gn-gemtext-7a83f48ed8576503d7389568f3844d12ab397060.tar.gz |
New Issue: Collections Count Bug
-rw-r--r-- | issues/collections_count_bug.gmi | 13 | ||||
-rw-r--r-- | issues/import_collections_popup_bug.gmi | 6 |
2 files changed, 19 insertions, 0 deletions
diff --git a/issues/collections_count_bug.gmi b/issues/collections_count_bug.gmi new file mode 100644 index 0000000..a3778bf --- /dev/null +++ b/issues/collections_count_bug.gmi @@ -0,0 +1,13 @@ +# Collections Count Bug + +## Tags + +* assigned: fredm +* priority: medium +* type: bug +* status: open +* keywords: collections + +## Description + +If the user creates even a single collection, a default collection with the name `Your Default Collection` gets created. This collection will sometimes be empty and therefore doesn't show up on the page. It, however, counts towards the total displayed on the badge. diff --git a/issues/import_collections_popup_bug.gmi b/issues/import_collections_popup_bug.gmi index 8fda79b..a1bde1d 100644 --- a/issues/import_collections_popup_bug.gmi +++ b/issues/import_collections_popup_bug.gmi @@ -21,3 +21,9 @@ To reproduce: The reason for this seems pretty clear after looking at the code. There's something in the index page template that checks if anon_collections > 0, and it shows the pop-up if it is. So importing collections naturally doesn't get rid of this, since anon_collections still exist (which is desirable, since they should still be accessible if the user logs out). I'm not sure how to deal with this. The only thing I can think of is having some sort of flag indicating "collections have already been imported," but I'm not sure where to put that flag. And ideally it also needs to detect if there's any overlap between existing collections and the anon_collections (I'm not sure if it does this currently). + +## Notes + +Discovered new issue while troubleshooting this one: + +=> issues/collections_count_bug Collections Count Bug |