summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorzsloan2024-05-31 16:32:42 -0500
committerGitHub2024-05-31 16:32:42 -0500
commit778817013c081480e7f84bf327ad16a8ca4fe61e (patch)
treeebc7b99d0300abe644a54395a0706a661cb0c0ab
parent6460ff889bdeac659f1e7aa0c4d1e9e7d5030001 (diff)
downloadgn-gemtext-778817013c081480e7f84bf327ad16a8ca4fe61e.tar.gz
Close issue
-rw-r--r--issues/genenetwork2/sort-by-attributes.gmi17
1 files changed, 16 insertions, 1 deletions
diff --git a/issues/genenetwork2/sort-by-attributes.gmi b/issues/genenetwork2/sort-by-attributes.gmi
index 68ef2ce..df1b2a3 100644
--- a/issues/genenetwork2/sort-by-attributes.gmi
+++ b/issues/genenetwork2/sort-by-attributes.gmi
@@ -5,7 +5,7 @@
* assigned: zachs, fredm
* type: feature-request, feature request
* priority: high
-* status: open
+* status: closed
* keywords: genenetwork2, sorting, attributes
## Description
@@ -33,8 +33,23 @@ myarr.toSorted((a, b) => {
return a - b;
}
});
+
+
```
to ensure that null values always come last.
Mixed lists are going to have to be sorted in alphabetical order, I guess, while still ensuring nulls end up last with something like the above.
+
+### Fixed
+
+With commit https://github.com/genenetwork/genenetwork2/commit/4c4d91d03a873969315727918206097a0d89bb19
+
+The sort functions in search_results.js were moved into table_functions.js so they could be used by more pages.
+In this case, the trait page needed access so that the case attribute columns could be sorted such that NA/NULL value
+are always at the bottom.
+
+
+
+
+