summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorFrederick Muriuki Muriithi2023-11-28 09:49:49 +0300
committerFrederick Muriuki Muriithi2023-11-28 09:49:49 +0300
commit57f99c69dd86cf25b2d7f290eb415a11c9cd167c (patch)
tree191b4cc04cb1b84e4ffa2f24034c2906ee01b3ef
parent400bac3a9142c872d6b57015e8fe8aa8f064b14e (diff)
downloadgn-gemtext-57f99c69dd86cf25b2d7f290eb415a11c9cd167c.tar.gz
Close issue.
-rw-r--r--issues/editing-bug-conflating-dataset_id-with-inbred_set_id.gmi6
1 files changed, 5 insertions, 1 deletions
diff --git a/issues/editing-bug-conflating-dataset_id-with-inbred_set_id.gmi b/issues/editing-bug-conflating-dataset_id-with-inbred_set_id.gmi
index b86e3da..525264d 100644
--- a/issues/editing-bug-conflating-dataset_id-with-inbred_set_id.gmi
+++ b/issues/editing-bug-conflating-dataset_id-with-inbred_set_id.gmi
@@ -3,13 +3,17 @@
## Tags
* type: bug
-* status: open
+* status: closed
* assigned: fredm, bonz
* keywords: editing
* priority: critical
## Description
+The issue described here should no longer exist after all the changes done for the editing work.
+
+----
+
The existing code that handles editing of phenotypes conflates the `dataset_id` with the `inbred_set_id` in a number of places. This is a subtle, but insidious bug that might lead to the end user editing the wrong data, if the values for both these values ever differs.
We need to do the appropriate indirections to fetch the group (InbredSet) details from the `dataset_id`.