diff options
| author | Frederick Muriuki Muriithi | 2024-04-17 02:48:59 +0300 |
|---|---|---|
| committer | Frederick Muriuki Muriithi | 2024-04-17 02:48:59 +0300 |
| commit | 54199f5639846eaeddfcfd352e26b7b72ca1b679 (patch) | |
| tree | 3043fa7ee82b1ba66bfe00788191d095a54c9727 | |
| parent | e1cfcced925e5f290c67b0194817b1af907ddeb6 (diff) | |
| download | gn-gemtext-54199f5639846eaeddfcfd352e26b7b72ca1b679.tar.gz | |
close issue.
| -rw-r--r-- | issues/gn-uploader/data-integrity-for-table-ids.gmi | 10 |
1 files changed, 9 insertions, 1 deletions
diff --git a/issues/gn-uploader/data-integrity-for-table-ids.gmi b/issues/gn-uploader/data-integrity-for-table-ids.gmi index 7e9d815..47bf813 100644 --- a/issues/gn-uploader/data-integrity-for-table-ids.gmi +++ b/issues/gn-uploader/data-integrity-for-table-ids.gmi @@ -3,9 +3,9 @@ ## Tags * type: bug -* status: open * assigned: fredm * priority: critical +* status: closed, completed * keywords: data integrity, mariadb, gn-uploader ## Description @@ -37,3 +37,11 @@ To see the modules that need to be updated, do $ cd /path/to/gn-uploader/ $ find ./ -name '*.py' -print0 | xargs --no-run-if-empty --null --max-procs=7 grep 'MAX(Id)' ``` + +The changes proposed above only work for single inserts; it will not work for `executemany()` calls like those present in the following files: + +* scripts/insert_data.py +* scripts/rqtl2/install_phenos.py +* scripts/rqtl2/install_genotypes.py + +For these, we have to retain the `SELECT MAX(Id) …` form. |