diff options
| author | zsloan | 2023-02-13 13:36:45 -0600 |
|---|---|---|
| committer | GitHub | 2023-02-13 13:36:45 -0600 |
| commit | 3a23d9cf6b922a6bcb49ff1c904623a28ee817f8 (patch) | |
| tree | fb92e7d14eb401c4f1c94dc896d3bc4b8127cce6 | |
| parent | 71590b1c42e0881fd1d6049f05716b63a9096039 (diff) | |
| download | gn-gemtext-3a23d9cf6b922a6bcb49ff1c904623a28ee817f8.tar.gz | |
Update/Close trait-page-mapping-bug issue
| -rw-r--r-- | issues/trait-page-mapping-bug.gmi | 8 |
1 files changed, 7 insertions, 1 deletions
diff --git a/issues/trait-page-mapping-bug.gmi b/issues/trait-page-mapping-bug.gmi index ba6ea4d..b3e6721 100644 --- a/issues/trait-page-mapping-bug.gmi +++ b/issues/trait-page-mapping-bug.gmi @@ -5,7 +5,7 @@ * assigned: zsloan * type: bug * priority: high -* status: ongoing +* status: completed * keywords: mapping, trait-page ## Description @@ -13,3 +13,9 @@ The user sometimes gets a 405 error when they click the "Compute" button on the trait page. This is because the page needs to fully load in beforehand, which can take up to a couple seconds. I'm not sure how best to address this. The most simple option would be to have the Compute button be greyed out until all the JS is finished loading. I'll probably do this for now, since I'm not sure how else to address the issue of the DataTable needing to load in (since it needs to be in the DOM in order for the sample values to be used in mapping). + +## Updates + +I ended up defaulting the mapping compute buttons to be disabled and say "Loading..."; they're then enabled and have their text changed back to "Compute" after the DataTables have finished loading in. + +A good trait for testing this (because it has a giant table that takes a long time to load) is this - https://genenetwork.org/show_trait?trait_id=10011&dataset=BXD-LongevityPublish |