diff options
| author | Alexander | 2022-04-07 12:17:10 +0300 |
|---|---|---|
| committer | Alexander | 2022-04-07 12:17:10 +0300 |
| commit | 0fb230f24d3714356d7735ce08860ac66ba16d9c (patch) | |
| tree | 5b369e7c00911f7c6e1934b27a2ad5f7a2b855d0 | |
| parent | 6c2c9342bd3f2348ed2b8d526c8b4260aa1b16dc (diff) | |
| parent | 3a8e38207ed67cd4ecdee8f8fc8a83109fb2e635 (diff) | |
| download | gn-gemtext-0fb230f24d3714356d7735ce08860ac66ba16d9c.tar.gz | |
Merge branch 'main' of https://github.com/genenetwork/gn-gemtext-threads into main
| -rw-r--r-- | issues/fix-case-attribute-work.gmi | 38 | ||||
| -rw-r--r-- | issues/sql-too-many-connections.gmi | 18 |
2 files changed, 45 insertions, 11 deletions
diff --git a/issues/fix-case-attribute-work.gmi b/issues/fix-case-attribute-work.gmi index 08462bf..3724998 100644 --- a/issues/fix-case-attribute-work.gmi +++ b/issues/fix-case-attribute-work.gmi @@ -1,19 +1,35 @@ -# Fix Case Attribute Work +# Fix Case Attribute Work (Same Columns) ## Tags * assigned: bonfacem * type: bug -* keywords: case attributes, data editing +* keywords: case attributes, data editing, done ## Tasks -* [ ] Parse things in "brackets" -* [ ] When editing columns with the same header: -* [ ] Check whether there's an ID. If so: -* [ ] Get the case attribute ID in brackets when in caseattributeXRef -* [ ] Else, do the fetching in SQL -* [ ] Check whether there's an -* [ ] Rollbacks ("conn.rollback()") -* [ ] Consecutive inserts with same values -* [ ] Consecutive deletions +* [x] Parse things in "brackets" +* [x] When editing columns with the same header: +* [x] Check whether there's an ID. If so: +* [x] Get the case attribute ID in brackets when in caseattributeXRef +* [x] Else, do the fetching in SQL +* [x] Check whether there's an +* [x] Rollbacks ("conn.rollback()") +* [-] Consecutive inserts with same values +* [-] Consecutive deletions + +### Notes: 06/04/22 + +Most of these issues have been addressed in these 2 PRs: + +=> https://github.com/genenetwork/genenetwork3/pull/90 +=> https://github.com/genenetwork/genenetwork2/pull/695 + +The last 2 elements in the tasks have been moved out to their own tasks. + +=> https://github.com/genenetwork/gn-gemtext-threads/commit/a75b726a008012b83c1ad25b330d43aabd711ee3 + +Also, wrt UI issues see: + +=> https://issues.genenetwork.org/issues/metadata-edits-improvements.html + diff --git a/issues/sql-too-many-connections.gmi b/issues/sql-too-many-connections.gmi new file mode 100644 index 0000000..e80beaa --- /dev/null +++ b/issues/sql-too-many-connections.gmi @@ -0,0 +1,18 @@ +# MySQLdb._exceptions.OperationalError: (1040, 'Too many connections') + +## Tags + +* assigned: bonfacem, fredm, aruni +* type: bug +* keywords: mysql, database + +## Tasks + +* [ ] Figure out root cause +* [ ] Send patch + +## Description + +See the strack trace present in this page: + +=> https://ci.genenetwork.org/jobs/genenetwork2/214 |