From 95e65819fd4155f539734a5de2eb108d232703a6 Mon Sep 17 00:00:00 2001 From: Frederick Muriuki Muriithi Date: Mon, 4 Nov 2024 16:54:45 -0600 Subject: Move logging setup functions to gn_auth.__init__.py module To ensure that logging will always be setup correctly, move the functions into the __init__.py module and call it within the create_app(..) function as before. --- gn_auth/wsgi.py | 31 +------------------------------ 1 file changed, 1 insertion(+), 30 deletions(-) (limited to 'gn_auth/wsgi.py') diff --git a/gn_auth/wsgi.py b/gn_auth/wsgi.py index bb8abd2..4904da3 100644 --- a/gn_auth/wsgi.py +++ b/gn_auth/wsgi.py @@ -3,7 +3,6 @@ import os import sys import uuid import json -import logging from math import ceil from pathlib import Path from typing import Callable @@ -24,35 +23,7 @@ from gn_auth.auth.authorisation.users.admin.models import make_sys_admin from scripts import register_sys_admin as rsysadm# type: ignore[import] -def dev_loggers(appl: Flask) -> None: - """Setup the logging handlers.""" - stderr_handler = logging.StreamHandler(stream=sys.stderr) - appl.logger.addHandler(stderr_handler) - - root_logger = logging.getLogger() - root_logger.addHandler(stderr_handler) - root_logger.setLevel(appl.config["LOGLEVEL"]) - - -def gunicorn_loggers(appl: Flask) -> None: - """Use gunicorn logging handlers for the application.""" - logger = logging.getLogger("gunicorn.error") - appl.logger.handlers = logger.handlers - appl.logger.setLevel(logger.level) - - -def setup_loggers() -> Callable[[Flask], None]: - """ - Setup the loggers according to the WSGI server used to run the application. - """ - # https://datatracker.ietf.org/doc/html/draft-coar-cgi-v11-03#section-4.1.17 - # https://wsgi.readthedocs.io/en/latest/proposals-2.0.html#making-some-keys-required - # https://peps.python.org/pep-3333/#id4 - software, *_version_and_comments = os.environ.get( - "SERVER_SOFTWARE", "").split('/') - return gunicorn_loggers if bool(software) else dev_loggers - -app = create_app(setup_logging=setup_loggers()) +app = create_app() ##### BEGIN: CLI Commands ##### -- cgit v1.2.3