diff options
| author | Frederick Muriuki Muriithi | 2024-02-27 05:07:41 +0300 |
|---|---|---|
| committer | Frederick Muriuki Muriithi | 2024-02-27 05:07:41 +0300 |
| commit | f77b169c09be92014dcfea49d427268381fe12e5 (patch) | |
| tree | 6a73659cb645b13c1ac409dcb7b124ba0165b69a | |
| parent | 15930e2d90894026083a8b21d2fef88562188a7a (diff) | |
| download | gn-ai-f77b169c09be92014dcfea49d427268381fe12e5.tar.gz | |
Update issues, closing some that are complete.
| -rw-r--r-- | issues/authentication_authorisation/rework-resources-system.gmi | 12 | ||||
| -rw-r--r-- | issues/authentication_authorisation/temp-trait-error.gmi | 4 | ||||
| -rw-r--r-- | issues/error-handling-external-errors.gmi | 6 | ||||
| -rw-r--r-- | issues/gn-uploader/rework-tests-remove-redis-as-test-dependency.gmi (renamed from issues/gnqc-py/rework-tests-remove-redis-as-test-dependency.gmi) | 8 | ||||
| -rw-r--r-- | issues/gn-uploader/upload-strains.gmi (renamed from issues/gnqc-py/upload-strains.gmi) | 2 | ||||
| -rw-r--r-- | issues/quality-control/Fix-opaque-errors.gmi | 4 | ||||
| -rw-r--r-- | issues/quality-control/qc-fix-integration-tests.gmi | 10 | ||||
| -rw-r--r-- | issues/quality-control/read-samples-from-database-by-species.gmi | 6 |
8 files changed, 37 insertions, 15 deletions
diff --git a/issues/authentication_authorisation/rework-resources-system.gmi b/issues/authentication_authorisation/rework-resources-system.gmi index eeec47d3..85d37a19 100644 --- a/issues/authentication_authorisation/rework-resources-system.gmi +++ b/issues/authentication_authorisation/rework-resources-system.gmi @@ -3,10 +3,10 @@ ## Tags * assigned: fredm -* status: open +* status: closed, completed * priority: medium * type: refactor, feature request, design change -* keywords: auth, authorisation, resources, design change +* keywords: auth, authorisation, resources, design change, gn-auth ## Description @@ -29,3 +29,11 @@ This means that there is a need to refactor the code to make the concept of a "r * [x] Make resource to represent the system itself * [x] Make resources, each representing one of the "user groups" * [ ] Make resources, each representing the users of the system -- maybe? + +### Update 2024-02-27 + +The resource system was updated a while ago. + +We still do not view users as resources for the time being, and handle them slightly different from the rest of the system, controlling access to the users via other resources like the 'System' and 'Group' resources. + +This is considered completed. diff --git a/issues/authentication_authorisation/temp-trait-error.gmi b/issues/authentication_authorisation/temp-trait-error.gmi index 04ab99d5..cc5d6db0 100644 --- a/issues/authentication_authorisation/temp-trait-error.gmi +++ b/issues/authentication_authorisation/temp-trait-error.gmi @@ -4,8 +4,8 @@ * assigned: fredm, zsloan * priority: high -* status: open -* keywords: authentication, authorisation, oauth2, temp-traits +* status: closed, completed +* keywords: authentication, authorisation, oauth2, temp-traits, gn-auth * type: bug ## Description diff --git a/issues/error-handling-external-errors.gmi b/issues/error-handling-external-errors.gmi index 9208a5df..d1707de5 100644 --- a/issues/error-handling-external-errors.gmi +++ b/issues/error-handling-external-errors.gmi @@ -27,3 +27,9 @@ So far, the error-handling for such services has been inconsistent at best. In t > => https://github.com/genenetwork/genenetwork2/pull/830 We can then maybe incorporate the use of UUIDs in the errors, to help with tracking the errors in the logs where necessary. + +---- + +Some work has been done on this, but it is still a work in progress. + +**Maybe link the commits hereā¦** diff --git a/issues/gnqc-py/rework-tests-remove-redis-as-test-dependency.gmi b/issues/gn-uploader/rework-tests-remove-redis-as-test-dependency.gmi index c4ee5e8b..a3054162 100644 --- a/issues/gnqc-py/rework-tests-remove-redis-as-test-dependency.gmi +++ b/issues/gn-uploader/rework-tests-remove-redis-as-test-dependency.gmi @@ -3,9 +3,9 @@ ## Tags * assigned: fred, fredm -* status: open +* status: closed, completed * priority: medium -* keywords: gnqc-py, tests +* keywords: gn-uploader, tests * type: improvement ## Description @@ -13,3 +13,7 @@ Some tests depend on a running redis instance to work. Either move these to an integration tests harness, to be run after the system has run the unit tests and has been deployed, or remove them completely from the system. + +### Update 2024-02-27 + +The system was updated to use prefixed keys, and the full tests now run correctly. Still need to add the tests to the guix CI/CD system perhaps... diff --git a/issues/gnqc-py/upload-strains.gmi b/issues/gn-uploader/upload-strains.gmi index 4815a061..6dce6bfc 100644 --- a/issues/gnqc-py/upload-strains.gmi +++ b/issues/gn-uploader/upload-strains.gmi @@ -6,7 +6,7 @@ * assigned: fredm, zachs, zsloan, acenteno * priority: high * type: feature-request -* keywords: QC, quality control, strains +* keywords: QC, quality control, strains, gn-uploader ## Description diff --git a/issues/quality-control/Fix-opaque-errors.gmi b/issues/quality-control/Fix-opaque-errors.gmi index 0f81233d..3864c813 100644 --- a/issues/quality-control/Fix-opaque-errors.gmi +++ b/issues/quality-control/Fix-opaque-errors.gmi @@ -2,11 +2,11 @@ ## Tags -* status: open +* status: closed, completed * assigned: fredm * type: bug * priority: high -* keywords: opaque errors, errors, UX, user experience +* keywords: opaque errors, errors, UX, user experience, gn-uploader ## Description diff --git a/issues/quality-control/qc-fix-integration-tests.gmi b/issues/quality-control/qc-fix-integration-tests.gmi index cf0b8335..c233c20d 100644 --- a/issues/quality-control/qc-fix-integration-tests.gmi +++ b/issues/quality-control/qc-fix-integration-tests.gmi @@ -4,8 +4,8 @@ * assigned: fredm * priority: medium -* status: open -* keywords: quality control, qc, tests +* status: closed, completed +* keywords: quality control, qc, tests, gn-uploader * type: bug ## Description @@ -19,3 +19,9 @@ command = [shutil.which("redis-server"), "--port", str(port)] This is because the `shutil.which("redis-server")` call returns `None` in the newer code, due to removal of redis (the server) from the list of dependencies. To work around the issue, I suggest the use of an explicit, albeit temporary, redis database for testing, by modifying the `REDIS_URL` value in the tests sessions. The modification will simply change the URL to point to a new database for the test session, enabling the tests to run unhindered, but also without tainting the production redis databases. + +### Update 2024-02-27 + +The system was updated to use prefixed keys, and the full tests now run correctly. + +=> /issues/gn-uploader/rework-tests-remove-redis-as-test-dependency related issue diff --git a/issues/quality-control/read-samples-from-database-by-species.gmi b/issues/quality-control/read-samples-from-database-by-species.gmi index fae1a184..fa66c174 100644 --- a/issues/quality-control/read-samples-from-database-by-species.gmi +++ b/issues/quality-control/read-samples-from-database-by-species.gmi @@ -5,8 +5,8 @@ * type: bug * priority: critical * assigned: fredm, acenteno -* keywords: QC, quality control, samples, strains, cases -* status: open +* keywords: QC, quality control, samples, strains, cases, gn-uploader +* status: closed, completed ## Description @@ -30,5 +30,3 @@ This was a myopic view of the data uploader, and needs to be expanded significan Fixed with this commit: => https://gitlab.com/fredmanglis/gnqc_py/-/commit/cdd4dc456e56bb4eb055e1cb7f2518d45fb3bfb9 - -Awaiting deployment |
