diff options
| author | Frederick Muriuki Muriithi | 2026-01-05 12:14:59 -0600 |
|---|---|---|
| committer | Frederick Muriuki Muriithi | 2026-01-05 12:14:59 -0600 |
| commit | 2ceded012ee33bee5dac574f1ee2d06ae5b3198a (patch) | |
| tree | fa123ebcf0170467fcfaecf6fb3db3a55abb4032 | |
| parent | 845fc81932d9b66c415efbb6aeff8f25848979bc (diff) | |
| download | gn-ai-2ceded012ee33bee5dac574f1ee2d06ae5b3198a.tar.gz | |
GN2: Collections - New issue.
| -rw-r--r-- | issues/genenetwork2/error-adding-trait-to-collections-while-logged-out.gmi | 29 |
1 files changed, 29 insertions, 0 deletions
diff --git a/issues/genenetwork2/error-adding-trait-to-collections-while-logged-out.gmi b/issues/genenetwork2/error-adding-trait-to-collections-while-logged-out.gmi new file mode 100644 index 00000000..4048f3e9 --- /dev/null +++ b/issues/genenetwork2/error-adding-trait-to-collections-while-logged-out.gmi @@ -0,0 +1,29 @@ +# Error Adding Trait(s) to Collection(s) While Logged Out + +## Tags + +* type: bug +* status: open +* priority: high +* assigned: zachs, fredm +* keywords: gn2, genenetwork2, genenetwork 2, collections + +## Description + +### Steps to Reproduce +* Go to https://genenetwork.org/ +* Ensure you are logged out +* Now, navigate to https://genenetwork.org/show_trait?trait_id=1435464_at&dataset=HC_M2_0606_P +* Click green "Add" button +* Note silent failure, then "MissingTokenError: missing_token: Please log in again to continue." notification + +### Expected + +On clicking "Add" we should have got a modal dialog with a selection of collections we can add the trait to. + +### Notes + +#### Cause of Failure + +=> https://github.com/genenetwork/genenetwork2/blob/c057054b69e673108410894ce87c5059aebb7b68/gn2/wqflask/collect.py#L81-L84 +The first fetch with ``oauth2_get`` fails in the case where the user is not logged in, raising a "MissingToken" exception. This then is handled by the default handlers and we get presented the prompt to login. |