From 08c81b8892060353bb7fb15555875f03bbdcb46e Mon Sep 17 00:00:00 2001
From: Frederick Muriuki Muriithi
Date: Fri, 19 Nov 2021 10:56:35 +0300
Subject: Avoid rounding: compare floats approximately

Notes:
https://github.com/genenetwork/genenetwork3/pull/56#issuecomment-973798918

* As mentioned in the notes, rather than rounding to an arbitrary number of
  decimal places, it is a much better practice to use approximate comparisons
  of floats for the tests.
---
 gn3/computations/partial_correlations.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

(limited to 'gn3')

diff --git a/gn3/computations/partial_correlations.py b/gn3/computations/partial_correlations.py
index ee47290..4f45159 100644
--- a/gn3/computations/partial_correlations.py
+++ b/gn3/computations/partial_correlations.py
@@ -156,7 +156,7 @@ def tissue_correlation(
         "Method must be one of: {}".format(",".join(method_fns.keys())))
 
     corr, pvalue = method_fns[method](primary_trait_values, target_trait_values)
-    return (round(corr, 10), round(pvalue, 10))
+    return (corr, pvalue)
 
 def batch_computed_tissue_correlation(
         primary_trait_values: Tuple[float, ...], target_traits_dict: dict,
-- 
cgit v1.2.3