From 773c0896ccbed12170be2b5aed4554ab86d923b5 Mon Sep 17 00:00:00 2001
From: Frederick Muriuki Muriithi
Date: Fri, 29 Oct 2021 08:00:27 +0300
Subject: Complete `build_temporary_tissue_correlations_table`

Issue:
https://github.com/genenetwork/gn-gemtext-threads/blob/main/topics/gn1-migration-to-gn2/partial-correlations.gmi

* gn3/computations/partial_correlations.py: Remove comments after updating
  usage of the function at call point
* gn3/db/correlations.py: Complete the implementation of the
  `build_temporary_tissue_correlations_table` function
---
 gn3/computations/partial_correlations.py | 13 -------------
 1 file changed, 13 deletions(-)

(limited to 'gn3/computations')

diff --git a/gn3/computations/partial_correlations.py b/gn3/computations/partial_correlations.py
index d095185..5777a0b 100644
--- a/gn3/computations/partial_correlations.py
+++ b/gn3/computations/partial_correlations.py
@@ -173,19 +173,6 @@ def correlations_of_all_tissue_traits(
     `web.webqtl.correlation.correlationFunction.calculateCorrOfAllTissueTrait`
     function in GeneNetwork1.
     """
-    # The section below existed in the original function, but with the migration
-    # and the proposed rework (in the near future), the values from the database
-    # should be passed into this function, rather than have the function fetch
-    # the data for itself.
-    # ---------------------------------------------------
-    # primary_trait_symbol_value_dict = fetch_gene_symbol_tissue_value_dict_for_trait(
-    #     (trait_symbol,), probeset_freeze_id, conn)
-    # primary_trait_values = primary_trait_symbol_value_dict.vlaues()[0]
-    # symbol_value_dict = fetch_gene_symbol_tissue_value_dict_for_trait(
-    #     tuple(), probeset_freeze_id, conn)
-    # ---------------------------------------------------
-    # We might end up actually getting rid of this function all together as the
-    # rework is done.
     primary_trait_values = primary_trait_symbol_value_dict.values()[0]
     return batch_computed_tissue_correlation(
         primary_trait_values, symbol_value_dict, method)
-- 
cgit v1.2.3