| Age | Commit message (Expand) | Author |
|---|
| 2022-05-24 | New script to compute partial correlations...* Add a new script to compute the partial correlations against:
- a select list of traits, or
- an entire dataset
depending on the specified subcommand. This new script is meant to supercede
the `scripts/partial_correlations.py` script.
* Fix the check for errors
* Reorganise the order of arguments for the
`partial_correlations_with_target_traits` function: move the `method`
argument before the `target_trait_names` argument so that the common
arguments in the partial correlation computation functions share the same
order.
| Frederick Muriuki Muriithi |
| 2022-05-21 | Use multiprocessing to improve performance | Frederick Muriuki Muriithi |
| 2022-05-21 | Process primary, target and control traits in a single iteration...Rework the code to process the traits in a single iteration to improve
performance.
| Frederick Muriuki Muriithi |
| 2022-05-21 | Return generator object rather than tuples...Return generator objects rather than pre-computed tuples to reduce the number
of iterations needed to process the data, and thus improve the performance of
the system somewhat.
| Frederick Muriuki Muriithi |
| 2022-05-06 | Fix linting and typing errors | Frederick Muriuki Muriithi |
| 2022-05-06 | Hook up pcorrs with target traits computations...Enable the endpoint to actually compute partial correlations with selected
target traits rather than against an entire dataset.
Fix some issues caused by recent refactor that broke pcorrs against a dataset
| Frederick Muriuki Muriithi |
| 2022-05-05 | Compute partial correlation with selected traits...Compute partial correlations against a selection of traits rather than against
an entire dataset.
| Frederick Muriuki Muriithi |
| 2022-05-05 | Extract common error checking. Rename function....* Extract the common error checking code into a separate function
* Rename the function to make its use clearer
| Frederick Muriuki Muriithi |
| 2022-05-03 | Refactor: Remove unnecessary loop...Remove an unnecessary looping construct to help with speeding up the partial
correlations somewhat.
| Frederick Muriuki Muriithi |
| 2022-03-29 | Remove unused module...* Remove a module that is no longer in use
| Frederick Muriuki Muriithi |
| 2022-03-23 | Run python-black on file and fix other pylint issues....See: <https://ci.genenetwork.org/jobs/genenetwork3-pylint/126>
* gn3/computations/rqtl.py: Run `black gn3/computations/rqtl.py`. Also,
manually fix other pylint issues.
| BonfaceKilz |
| 2022-03-22 | Fixes pylint errors | zsloan |
| 2022-03-22 | Fixed mypy typing errors | zsloan |
| 2022-03-22 | Tried to make the docstrings more consistent | zsloan |
| 2022-03-22 | Add typing to some functions | zsloan |
| 2022-03-22 | Add functions for getting proximal/distal markers for each pseudomarker posit... | zsloan |
| 2022-03-22 | Added genofile name to inputs for processing R/qtl pair-scan results, since i... | zsloan |
| 2022-03-22 | Removed quotes from beginning and end of chromosome string | zsloan |
| 2022-03-22 | Fixed a cople function calls to use the updated function names | zsloan |
| 2022-03-22 | Create pairscan_for_figure and pairscan_for_table functions that return the D... | zsloan |
| 2022-03-22 | Added pairscan boolean kwarg and process_rqtl_pairscan function for reading i... | zsloan |
| 2022-03-15 | Feature/refactored pca (#79)...* compute zscore function
* test case for computing zscore
* function to compute pca
* generate scree plot data
* generate new pca trait data from zscores and eigen_vec
* remove redundant functions
* generate factor loading table data
* generate pca temp dataset dict
* variable naming and error fixes
* unit test for processing factor loadings
* minor fixes for generating temp pca dataset
* pass datetime as argument to generate_pca temp dataset function
* add unittest for caching pca datasets
* cache temp datasets
* ignore missing imports for sklearn
* mypy fixes
* pylint fixes
* refactor tests for pca
* remove ununsed imports
* fix for generating pca traits vals
* mypy and code refactoring
* pep8 formatting and add docstrings
* remove comments /pep8 formatting
* sort eigen vectors based on eigen values
* minor fix for zscores
* fix for rounding variance ratios
* refactor tests
* rename module to pca
* rename datasets to traits
* fix failing tests
* fix caching function
* fixes return x and y coordinates for scree plot
* expand exception scope
* fix for deprecated numpy.matrix function
* fix for failing tests
* pep8 fixes
* remove comments
* fix merge conflict
* pylint fixes
* rename module name to test_pca | Alexander Kabui |
| 2022-03-11 | Fix typing errors | Frederick Muriuki Muriithi |
| 2022-03-08 | Remove unused function and its tests | Frederick Muriuki Muriithi |
| 2022-03-08 | Fix tests, and issues caught by tests...Fix some issues caught by tests due to changes introducing the hand-off of the
partial correlations computations to an external process
Fix some issues due to the changes that introduce context managers for
database connections
Update some tests to take the above two changes into consideration
| Frederick Muriuki Muriithi |
| 2022-02-25 | Fix issue where 0's were treated as False for the primary trait in...correlations
In the original version of the if statement* I believe it was
interpreted as "if a_val and (b_val is not None)". This caused
values of 0 for a_val (the primary trait's values) to be evaluated as
False.
I changed it to compare both a_val and b_val to None. This seems to have
fixed the issue.
* if (a_val and b_val is not None)
| zsloan |
| 2022-02-24 | gn3: computations: Call Popen with context manager....Context managers should be preferred when allocating resources.
* gn3/computations/wgcna.py (stream_cmd_output): Call Popen with context
manager.
| Arun Isaac |
| 2022-02-24 | gn3: Explicitly specify UTF-8 to be the file encoding....When the encoding is not specified explicitly, the system default encoding is
used. This is not recommended.
* gn3/computations/ctl.py (call_ctl_script),
gn3/computations/gemma.py (generate_pheno_txt_file),
gn3/computations/parsers.py (parse_genofile),
gn3/computations/partial_correlations.py (partial_correlations_fast),
gn3/computations/rqtl.py (process_rqtl_output, process_perm_output),
gn3/computations/wgcna.py (dump_wgcna_data, call_wgcna_script),
gn3/fs_helpers.py (jsonfile_to_dict): Explicitly specify UTF-8 to be the file
encoding.
*
tests/unit/computations/test_gemma.py (TestGemma.test_generate_pheno_txt_file),
tests/unit/computations/test_wgcna.py (TestWgcna.test_create_json_file): Test
for call to open with encoding='utf-8' argument.
| Arun Isaac |
| 2022-02-21 | Fix minor issues introduced while fixing linting errors | Frederick Muriuki Muriithi |
| 2022-02-21 | Fix a myriad of linter issues...* Use `with` in place of plain `open`
* Use f-strings in place of `str.format()`
* Remove string interpolation from queries - provide data as query parameters
* other minor fixes
| Frederick Muriuki Muriithi |
| 2022-02-21 | Test partial corrs API with mix of existing and non-existing control traits...Test that the partial correlations endpoint handles a mix of existing and
non-existing control traits gracefully and issues a warning to the user.
Summary of changes:
* gn3/computations/partial_correlations.py: Issue a warning for all
non-existing control traits
* gn3/db/partial_correlations.py: update queries - use `INNER JOIN` for tables
instead of comma-separated list of tables
* tests/integration/conftest.py: Add `db_conn` fixture to provide a database
connection to the tests. This will probably be changed in the future to
connect to a temporary database for tests.
* tests/integration/test_partial_correlations.py: Add test to check for
correct behaviour with a mix of existing and non-existing control traits
| Frederick Muriuki Muriithi |
| 2022-02-19 | Test partial corrs endpoint with non-existing control traits...Test that if the endpoint is queried and not a single one of the control
traits exists in the database, then the endpoint will respond with a
404 (not-found) status code.
Summary of changes:
* gn3/computations/partial_correlations.py: Check whether any control trait is
found. If none is found, return "not-found" message.
* gn3/db/partial_correlations.py: Fix bug in Geno query.
* tests/integration/test_partial_correlations.py: Add test for non-existing
control traits. Rename function to make it clearer what it is testing
for. Remove obsoleted comments.
| Frederick Muriuki Muriithi |
| 2022-02-18 | Test partial correlations endpoint with non-existent primary traits...Test that the partial correlations endpoint responds with an appropriate
"not-found" message and the corresponding 404 status code in the case where a
request is made and the primary trait requested for does not exist in the
database.
Summary of the changes in each file:
* gn3/api/correlation.py: generalise the building of the response
* gn3/computations/partial_correlations.py: return with a "not-found" if the
primary trait does not exist in the database
* gn3/db/partial_correlations.py: Fix a number of bugs that led to exceptions
in the case that the primary trait did not exist
* pytest.ini: register a `slow` pytest marker
* tests/integration/test_partial_correlations.py: Add a new test to check for
an appropriate 404 response in case of a primary trait that does not exist
in the database.
| Frederick Muriuki Muriithi |
| 2022-02-17 | Add property tests for `dictify_by_samples`...Add property tests using pytest and hypothesis to test that the expected
properties hold for the
`gn3.computations.partial_correlations.dictify_by_samples`
function.
| Frederick Muriuki Muriithi |
| 2022-02-08 | Merge iterations to remove unnecessary computations...Do all the work in a single iteration to avoid unnecessary iterations that
hamper performance.
| Frederick Muriuki Muriithi |
| 2022-02-08 | Remove multiprocessing for stability...Web servers are long-running processes, and python is not very good at
cleaning up after itself especially in forked processes - this leads to memory
errors in the web-server after a while.
This commit removes the use of multiprocessing to avoid such failures.
| Frederick Muriuki Muriithi |
| 2022-02-08 | Give sorting functions more descriptive names | Frederick Muriuki Muriithi |
| 2022-02-08 | Use multiprocessing to speed up computation...This commit refactors the code to make it possible to use multiprocessing to
speed up the computation of the partial correlations.
The major refactor is to move the `__compute_trait_info__` function to the
top-level of the module, and provide to it all the other necessary context via
the new args.
| Frederick Muriuki Muriithi |
| 2022-02-08 | Remove unnecessary computation...In Python3 when slicing,
seq[:min(some_val, len(seq))] == seq[:some_val]
because Python3 will just return a copy of the entire sequence if `some_val`
happens to be larger/greater than the length of the sequence.
This commit removes the unnecessary call to `min()`
| Frederick Muriuki Muriithi |
| 2022-02-02 | refactor code for invoking ctl script | Alexander Kabui |
| 2022-02-02 | pep8 formatting | Alexander Kabui |
| 2022-02-02 | new line fix | Alexander Kabui |
| 2022-02-02 | fix comprehension list | Alexander Kabui |
| 2022-01-22 | process ctl plot data img | Alexander Kabui |
| 2022-01-22 | read stdout data;handle exceptions | Alexander Kabui |
| 2022-01-22 | init file to call ctl script | Alexander Kabui |
| 2022-01-12 | Update return type. Remove duplicate import....The function is a generator function, since it uses a `yield` statement, and
thus returns a generator object, that contains a tuple object. This fixes
that. We also remove a duplicate import.
| Frederick Muriuki Muriithi |
| 2022-01-10 | Use the correct letter case for the keys...* Use the correct case for the keys inorder to retrieve the correct values.
| Frederick Muriuki Muriithi |
| 2022-01-10 | Indicate that string is an f-string...* The string had the f-string syntax to format the values to be inserted into
the string, but was missing the 'f' before the opening quotes to signify to
python that this was an f-string. This commit fixes that.
| Frederick Muriuki Muriithi |
| 2022-01-10 | Remove all pairs with 'None' as the value...* Remove all key-value pairs whose value is None.
| Frederick Muriuki Muriithi |
