aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2021-07-22Check that distance from A to B is same as from B to AMuriithi Frederick Muriuki
Issue: https://github.com/genenetwork/gn-gemtext-threads/blob/main/topics/gn1-migration-to-gn2/clustering.gmi * gn3/computations/slink.py: check that the distance from child A to B is the same as distance from child B to A. If not, throw an exception. * tests/unit/computations/test_slink.py: * Change the name of the test to more closely correspond to the business logic being tested. * Update the data in a separate test such that it does not error out due to failing to fulfill the expectations of separate requirement. - pass tests - Rename test - Fix errors: distances same both directions
2021-07-22Check that child distance from itself is zeroMuriithi Frederick Muriuki
Issue: https://github.com/genenetwork/gn-gemtext-threads/blob/main/topics/gn1-migration-to-gn2/clustering.gmi * gn3/computations/slink.py: Check that a child's distance from itself is zero. If not, throw an exception. The children lists are a list of distances of "something" from other "somethings". There is still some need to establish what those "somethings" are, so that the test names can reflect the ideas that are actually being tested for. * tests/unit/computations/test_slink.py: Change the name of the test so that it more closely corresponds to the business logic it is actually testing, and not the mechanics of testing the idea.
2021-07-22Check the child lengths are same as length of parentMuriithi Frederick Muriuki
Issue: https://github.com/genenetwork/gn-gemtext-threads/blob/main/topics/gn1-migration-to-gn2/clustering.gmi * Check that the child lists/tuples are the same length as the parent list/tuple. If any of the children is not the same length as the parent, throw and exception.
2021-07-22Add docstringMuriithi Frederick Muriuki
Issue: https://github.com/genenetwork/gn-gemtext-threads/blob/main/topics/gn1-migration-to-gn2/clustering.gmi * Add docstring to the function, useful for generating automated developer documentation. We also surround the guard functions with some notification comments, to mark possible future places where change might be done.
2021-07-22Check that list and its direct children are not emptyMuriithi Frederick Muriuki
Issue: https://github.com/genenetwork/gn-gemtext-threads/blob/main/topics/gn1-migration-to-gn2/clustering.gmi * Add code to pass the test that the list/tuple passed to `nearest' and its direct children lists/tuples are not empty.
2021-07-22Implement check for lists or tuplesMuriithi Frederick Muriuki
Issue: https://github.com/genenetwork/gn-gemtext-threads/blob/main/topics/gn1-migration-to-gn2/clustering.gmi * Implement the code to pass the check that a list of lists is passed to the `nearest' function.
2021-07-21Extract tests from code in GN1Muriithi Frederick Muriuki
Issue: https://github.com/genenetwork/gn-gemtext-threads/blob/main/topics/gn1-migration-to-gn2/clustering.gmi * gn3/computations/slink.py: Add dummy `nearest' function * tests/unit/computations/test_slink.py: Add some tests This commit adds tests to try and reproduce the working of the `nearest' function in: https://github.com/genenetwork/genenetwork1/blob/master/web/webqtl/heatmap/slink.py This commit might not yet have extracted all the expected behaviour of the `nearest' function, and therefore, there is a possibility of a later commit augmenting the work in this commit.
2021-07-20Implement the correlation functionMuriithi Frederick Muriuki
Issue: https://github.com/genenetwork/gn-gemtext-threads/blob/main/topics/gn1-migration-to-gn2/clustering.gmi * Implement the correlation computation function, such that it passes the tests created previously.
2021-07-20Add test for code to move over from GN1Muriithi Frederick Muriuki
Issue: https://github.com/genenetwork/gn-gemtext-threads/blob/main/topics/gn1-migration-to-gn2/clustering.gmi * .gitignore: ignore emacs temporary files * gn3/computations/correlations2.py: add a dummy function * tests/unit/computations/test_correlation.py: add unit tests for the function As part of the move of the clustering and heatmap code over from GN1 to GN3, this commit begins by providing some unit tests for the correlation function used to ensure that the implementation that is built up here corresponds, and produces the same results as the original. This tests and the function might change in the new system, but for now, we try and maintain bug-to-bug compatibility.
2021-07-10gn3: db: Use correct type for columns arg in fetch functionsBonfaceKilz
2021-07-10Fix pylint issuesBonfaceKilz
2021-07-10db: test_db: Test that a fetch is correct when columns are specifiedBonfaceKilz
2021-07-10gn3: db: Add extra argument to specify column in fetch statementsBonfaceKilz
2021-07-10db: phenotypes: Add Probeset data structuresBonfaceKilz
* gn3/db/phenotypes.py (Probeset): New dataclass. (probeset_mapping): New dict. * gn3/db/__init__.py: Add probeset_mapping and Probeset.
2021-06-29Replace list with a tuple as an argument when setting success_codesBonfaceKilz
* gn3/commands.py (run_cmd): Replace type of success_codes from List to Tuple * gn3/computations/diff.py (generate_diff): Pass success_codes as a Tuple when calling "run_cmd".
2021-06-29guix: Add diffutils as a propagated inputBonfaceKilz
2021-06-29guix: Remove commented out hunkBonfaceKilz
2021-06-29gn3: diff: Set success_codes when running the diff toolBonfaceKilz
2021-06-29gn3: commands: Add extra arg that sets the success codes to checkBonfaceKilz
* gn3/commands.py (run_cmd): Some commands like "diff" return non-standard error codes. To make this fn more robust, add an extra optional argument that sets what successful codes to check.
2021-06-29tests: test_commands: Add extra check for when an error occursBonfaceKilz
2021-06-29Add a diffing functionBonfaceKilz
For now the diff function uses the Linux tool "diff" to generate the diff since it is efficient and straightforward. * gn3/computations/diff.py (generate_diff): New function. * tests/unit/computations/test_diff.py: Test cases for ☝🏾.
2021-06-29tests: test_data: Add test data that contains trait data for 10007BonfaceKilz
2021-06-25Check for the correct result codeBonfaceKilz
When programs terminate with an error, they usually return a -1!
2021-06-23Merge pull request #21 from genenetwork/fix/biweight-errorsBonfaceKilz
Fix/biweight errors
2021-06-23fix pylint issuesAlexander Kabui
2021-06-23minor fixes for biweight scriptAlexander Kabui
2021-06-22scripts: laminar: Add json with hooks for running a linterBonfaceKilz
2021-06-22scripts: laminar: Add sh scripts for CIBonfaceKilz
2021-06-21Merge pull request #20 from genenetwork/feature/biweight-correlationBonfaceKilz
add biweight r script and tests
2021-06-20minor fix docstringAlexander Kabui
2021-06-20merge mainAlexander Kabui
2021-06-20fix conflictAlexander Kabui
2021-06-20make requested changes to biweightAlexander Kabui
2021-06-18Merge pull request #13 from zsloan/feature/add_rqtl_endpointszsloan
Feature/add rqtl endpoints
2021-06-18Fixed another error where test_generate_rqtl_command didn't include the ↵zsloan
filename argument (not sure why running unit tests locally doesn't detect this)
2021-06-18Fixed file type from json to csv for test_generate_rqtl_commandzsloan
2021-06-18Fixed test_rqtl.py to include Rscript in the commandzsloan
2021-06-18Fixed test_compose_rqtl_command test; forgot to include Rscript in the commandzsloan
2021-06-18Change test_compose_rqtl_command in test_commands.py to have different ↵zsloan
arguments to hopefully avoid github's pylint 'duplicate code' complaint Changed some parameters in test_compose_rqtl_cmd to avoid pylint complaining about duplicate code
2021-06-18Fixed pylint issueszsloan
2021-06-18add ignore_missing_imports for numpy in mypy.ini since it complains about ↵zsloan
that and we seem to have done the same thing for scipy
2021-06-18Resolve mypy errors in computations/rqtl.pyzsloan
2021-06-18Fixed spelling of coeffient to coefficientzsloan
2021-06-18minor fixesAlexander Kabui
2021-06-18remove ununsed variablesAlexander Kabui
2021-06-18refactor perf query functionsAlexander Kabui
2021-06-18rename perf query fileAlexander Kabui
2021-06-18pep8 formattingAlexander Kabui
2021-06-18add tests to setup packagesAlexander Kabui
2021-06-18add types and dataset namesAlexander Kabui
generated by cgit v1.2.3 (git 2.44.0) at 2024-11-23 07:39:06 +0000