aboutsummaryrefslogtreecommitdiff
path: root/tests/unit/auth/test_groups.py
diff options
context:
space:
mode:
authorFrederick Muriuki Muriithi2022-11-17 14:03:19 +0300
committerFrederick Muriuki Muriithi2022-11-17 14:03:19 +0300
commit8e0ed6fdb03d1a2c284a68a387105623c8947abd (patch)
tree2748c4dd713bce099565c02569463553f293beb9 /tests/unit/auth/test_groups.py
parentfb885e810f568a69e6703939062e532acf649a38 (diff)
downloadgenenetwork3-8e0ed6fdb03d1a2c284a68a387105623c8947abd.tar.gz
auth: Finish implementation of `create_group_role`
* gn3/auth/authorisation/groups.py: Add `GroupRole` type. Fix typing annotations. Fix bugs. * tests/unit/auth/conftest.py: Fix bugs. * tests/unit/auth/test_groups.py: Fix test to run.
Diffstat (limited to 'tests/unit/auth/test_groups.py')
-rw-r--r--tests/unit/auth/test_groups.py38
1 files changed, 27 insertions, 11 deletions
diff --git a/tests/unit/auth/test_groups.py b/tests/unit/auth/test_groups.py
index 0cd370e..9471cac 100644
--- a/tests/unit/auth/test_groups.py
+++ b/tests/unit/auth/test_groups.py
@@ -4,7 +4,10 @@ from uuid import UUID
import pytest
from gn3.auth import db
-from gn3.auth.authorisation.groups import Group, create_group, create_group_role
+from gn3.auth.authorisation.roles import Role
+from gn3.auth.authorisation.privileges import Privilege
+from gn3.auth.authorisation.groups import (
+ Group, GroupRole, create_group, create_group_role)
create_group_failure = {
"status": "error",
@@ -13,6 +16,13 @@ create_group_failure = {
uuid_fn = lambda : UUID("d32611e3-07fc-4564-b56c-786c6db6de2b")
+GROUP = Group(UUID("9988c21d-f02f-4d45-8966-22c968ac2fbf"), "TheTestGroup")
+PRIVILEGES = (
+ Privilege(
+ UUID("7f261757-3211-4f28-a43f-a09b800b164d"), "view-resource"),
+ Privilege(
+ UUID("2f980855-959b-4339-b80e-25d1ec286e21"), "edit-resource"))
+
@pytest.mark.unit_test
@pytest.mark.parametrize(
"user_id,expected", (
@@ -36,15 +46,22 @@ def test_create_group(# pylint: disable=[too-many-arguments]
with db.connection(auth_testdb_path) as conn:
assert create_group(conn, "a_test_group") == expected
+create_role_failure = {
+ "status": "error",
+ "message": "Unauthorised: Could not create the group role"
+}
+
@pytest.mark.unit_test
@pytest.mark.parametrize(
"user_id,expected", (
- ("ecb52977-3004-469e-9428-2a1856725c7f", Group(
- UUID("d32611e3-07fc-4564-b56c-786c6db6de2b"), "a_test_group")),
- ("21351b66-8aad-475b-84ac-53ce528451e3", create_group_failure),
- ("ae9c6245-0966-41a5-9a5e-20885a96bea7", create_group_failure),
- ("9a0c7ce5-2f40-4e78-979e-bf3527a59579", create_group_failure),
- ("e614247d-84d2-491d-a048-f80b578216cb", create_group_failure)))
+ ("ecb52977-3004-469e-9428-2a1856725c7f", GroupRole(
+ UUID("d32611e3-07fc-4564-b56c-786c6db6de2b"),
+ Role(UUID("d32611e3-07fc-4564-b56c-786c6db6de2b"),
+ "ResourceEditor", PRIVILEGES))),
+ ("21351b66-8aad-475b-84ac-53ce528451e3", create_role_failure),
+ ("ae9c6245-0966-41a5-9a5e-20885a96bea7", create_role_failure),
+ ("9a0c7ce5-2f40-4e78-979e-bf3527a59579", create_role_failure),
+ ("e614247d-84d2-491d-a048-f80b578216cb", create_role_failure)))
def test_create_group_role(mocker, test_users_in_group, test_app, user_id, expected):
"""
GIVEN: an authenticated user
@@ -54,9 +71,8 @@ def test_create_group_role(mocker, test_users_in_group, test_app, user_id, expec
"""
mocker.patch("gn3.auth.authorisation.groups.uuid4", uuid_fn)
mocker.patch("gn3.auth.authorisation.roles.uuid4", uuid_fn)
- conn, group, users = test_users_in_group
+ conn, _group, _users = test_users_in_group
with test_app.app_context() as flask_context:
flask_context.g.user_id = UUID(user_id)
- assert create_group_role(conn, GROUP, "a_test_role", PRIVILEGES)
-
- assert False, "NOT IMPLEMENTED"
+ assert create_group_role(
+ conn, GROUP, "ResourceEditor", PRIVILEGES) == expected