aboutsummaryrefslogtreecommitdiff
path: root/gn3/auth/db.py
diff options
context:
space:
mode:
authorFrederick Muriuki Muriithi2022-11-16 12:50:47 +0300
committerFrederick Muriuki Muriithi2022-11-16 13:03:56 +0300
commit25da0232ac52509d6761e36ad80ed53b8dbbb64e (patch)
treeb90570f2cea39def61ea34183a19766b0b0b5e52 /gn3/auth/db.py
parentc18e2485caa34a4ec978605b50a2e314441a78b1 (diff)
downloadgenenetwork3-25da0232ac52509d6761e36ad80ed53b8dbbb64e.tar.gz
auth: fix bugs in the code
* gn3/auth/authorisation/privileges.py: Set id to UUID type * gn3/auth/authorisation/roles.py: fix parameters to types that sqlite3 supports * gn3/auth/db.py: add logging for errors and re-raise the exception * tests/unit/auth/test_roles.py: fix test
Diffstat (limited to 'gn3/auth/db.py')
-rw-r--r--gn3/auth/db.py12
1 files changed, 10 insertions, 2 deletions
diff --git a/gn3/auth/db.py b/gn3/auth/db.py
index 8760153..e0e009c 100644
--- a/gn3/auth/db.py
+++ b/gn3/auth/db.py
@@ -3,6 +3,10 @@ import sqlite3
import contextlib
from typing import Any, Iterator, Protocol
+import traceback
+
+from flask import current_app as app
+
class DbConnection(Protocol):
"""Type annotation for a generic database connection object."""
def cursor(self) -> Any:
@@ -48,8 +52,10 @@ def connection(db_path: str) -> Iterator[DbConnection]:
conn = sqlite3.connect(db_path)
try:
yield conn
- except: # pylint: disable=bare-except
+ except sqlite3.Error as exc:
conn.rollback()
+ app.logger.debug(traceback.format_exc())
+ raise exc
finally:
conn.commit()
conn.close()
@@ -60,8 +66,10 @@ def cursor(conn: DbConnection) -> Iterator[DbCursor]:
cur = conn.cursor()
try:
yield cur
- except: # pylint: disable=bare-except
+ except sqlite3.Error as exc:
conn.rollback()
+ app.logger.debug(traceback.format_exc())
+ raise exc
finally:
conn.commit()
cur.close()