diff options
| author | Frederick Muriuki Muriithi | 2022-12-08 08:09:40 +0300 |
|---|---|---|
| committer | Frederick Muriuki Muriithi | 2022-12-08 08:35:42 +0300 |
| commit | 836924e7dccddaceb036fe3a312ca6811ccf2228 (patch) | |
| tree | b73fc2bdeac3fa4508d5219580965c0b9aa132a8 | |
| parent | b2e4621ba69a4fbbb9bd310aae6c9dee7339a3f5 (diff) | |
| download | genenetwork3-836924e7dccddaceb036fe3a312ca6811ccf2228.tar.gz | |
tests: Fix issues caught by tests
The addition of the `public` field in the `resources` table, led to some
previously passing tests to fail. This commit fixes the failures, and cleans
up some pylint issues.
* gn3/auth/authorisation/resources.py: add `public` to db queries
* tests/unit/auth/test_groups.py: fix pylint issues
| -rw-r--r-- | gn3/auth/authorisation/resources.py | 7 | ||||
| -rw-r--r-- | tests/unit/auth/test_groups.py | 2 |
2 files changed, 5 insertions, 4 deletions
diff --git a/gn3/auth/authorisation/resources.py b/gn3/auth/authorisation/resources.py index 2ddd865..095a72c 100644 --- a/gn3/auth/authorisation/resources.py +++ b/gn3/auth/authorisation/resources.py @@ -34,12 +34,13 @@ def create_resource( if not group: raise MissingGroupError( "User with no group cannot create a resource.") - resource = Resource(group, uuid4(), resource_name, resource_category) + resource = Resource(group, uuid4(), resource_name, resource_category, False) cursor.execute( - ("INSERT INTO resources VALUES (?, ?, ?, ?)"), + "INSERT INTO resources VALUES (?, ?, ?, ?, ?)", (str(resource.group.group_id), str(resource.resource_id), resource_name, - str(resource.resource_category.resource_category_id))) + str(resource.resource_category.resource_category_id), + 1 if resource.public else 0)) return resource diff --git a/tests/unit/auth/test_groups.py b/tests/unit/auth/test_groups.py index 79dc16f..9eef0e9 100644 --- a/tests/unit/auth/test_groups.py +++ b/tests/unit/auth/test_groups.py @@ -115,5 +115,5 @@ def test_user_group(test_users_in_group, user, expected): THEN: return a Maybe containing the group that the user belongs to, or Nothing """ - conn, group, users = test_users_in_group + conn, _group, _users = test_users_in_group assert user_group(conn, user).maybe(Nothing, lambda val: val) == expected |