diff options
| author | Frederick Muriuki Muriithi | 2022-02-11 05:45:24 +0300 |
|---|---|---|
| committer | Frederick Muriuki Muriithi | 2022-02-11 05:52:36 +0300 |
| commit | 651c8ad9ae20ab52e7ab694c0caa9d92774b49b5 (patch) | |
| tree | 65c1f4033a672e65b7b5b6a87acfca9811e2eae2 | |
| parent | fad6f623f204aa1064b48fe1d8cb575f270ac217 (diff) | |
| download | genenetwork3-651c8ad9ae20ab52e7ab694c0caa9d92774b49b5.tar.gz | |
Quote shell variables to prevent globbing
Quote the shell variables to prevent globbing and word splitting.
Deactivate this check for the specific lines that require intentional word
splitting
| -rw-r--r-- | scripts/laminar/gn3-lint.sh | 4 | ||||
| -rw-r--r-- | scripts/laminar/gn3-mypy.sh | 4 | ||||
| -rw-r--r-- | scripts/laminar/gn3-unittest.sh | 4 | ||||
| -rwxr-xr-x | sql/map-database.sh | 2 |
4 files changed, 8 insertions, 6 deletions
diff --git a/scripts/laminar/gn3-lint.sh b/scripts/laminar/gn3-lint.sh index b6f0c89..1299a96 100644 --- a/scripts/laminar/gn3-lint.sh +++ b/scripts/laminar/gn3-lint.sh @@ -4,7 +4,7 @@ set -e # Abort on first error CUR_DIR=$PWD GN3_CI_DIR=$HOME/CI/genenetwork3/ -cd $GN3_CI_DIR +cd "${GN3_CI_DIR}" git pull # Run Pylint @@ -12,4 +12,4 @@ env GUIX_PACKAGE_PATH="$HOME/guix-bioinformatics:$HOME/guix-past/modules" \ guix environment --load=guix.scm -- pylint sheepdog/worker.py gn3/ tests echo Done Running Pylint! -cd $CUR_DIR +cd "${CUR_DIR}" diff --git a/scripts/laminar/gn3-mypy.sh b/scripts/laminar/gn3-mypy.sh index a2a9782..6d04c35 100644 --- a/scripts/laminar/gn3-mypy.sh +++ b/scripts/laminar/gn3-mypy.sh @@ -4,7 +4,7 @@ set -e # Abort on first error CUR_DIR=$PWD GN3_CI_DIR=$HOME/CI/genenetwork3/ -cd $GN3_CI_DIR +cd "${GN3_CI_DIR}" git pull # Run Pylint @@ -12,4 +12,4 @@ env GUIX_PACKAGE_PATH="$HOME/guix-bioinformatics:$HOME/guix-past/modules" \ guix environment --load=guix.scm -- mypy . echo Done Running MyPy! -cd $CUR_DIR +cd "${CUR_DIR}" diff --git a/scripts/laminar/gn3-unittest.sh b/scripts/laminar/gn3-unittest.sh index 41dafe5..d18d5de 100644 --- a/scripts/laminar/gn3-unittest.sh +++ b/scripts/laminar/gn3-unittest.sh @@ -4,7 +4,7 @@ set -e # Abort on first error CUR_DIR=$PWD GN3_CI_DIR=$HOME/CI/genenetwork3/ -cd $GN3_CI_DIR +cd "${GN3_CI_DIR}" git pull # Run Pylint @@ -12,4 +12,4 @@ env GUIX_PACKAGE_PATH="$HOME/guix-bioinformatics:$HOME/guix-past/modules" \ guix environment --load=guix.scm -- python -m unittest discover echo Done Running Unittests! -cd $CUR_DIR +cd "${CUR_DIR}" diff --git a/sql/map-database.sh b/sql/map-database.sh index 2e4d1d7..35a435f 100755 --- a/sql/map-database.sh +++ b/sql/map-database.sh @@ -11,5 +11,7 @@ clusters="Others=AccessLog,Docs,Investigators,MachineAccessLog,News,Organization flags="--db MySQL --skip-tables $skip_tables --cluster $clusters" +# shellcheck disable=SC2086 # Intentional splitting of `flags` sqlt-graph $flags --output-type png --output schema.png schema.sql +# shellcheck disable=SC2086 # Intentional splitting of `flags` sqlt-graph $flags --output-type svg --output schema.svg schema.sql |