From 93939248fdaaa89a9e3b74027addd8ea64d1a8e9 Mon Sep 17 00:00:00 2001 From: Frederick Muriuki Muriithi Date: Wed, 5 Jul 2023 10:07:42 +0300 Subject: Get setting from config files on envvars The main code should only ever get its configs from the application configurations, and not directly from the envvars. This helps with maintenance by ensuring that the application configurations are done in one place, and can be traced for debugging purposes. --- wqflask/wqflask/metadata_edits.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/wqflask/wqflask/metadata_edits.py b/wqflask/wqflask/metadata_edits.py index 59cc3083..5b03f3ed 100644 --- a/wqflask/wqflask/metadata_edits.py +++ b/wqflask/wqflask/metadata_edits.py @@ -148,7 +148,7 @@ def display_phenotype_metadata(dataset_id: str, name: str): dataset_id=dataset_id, name=name, resource_id=request.args.get("resource-id"), - version=os.environ.get("GN_VERSION"), + version=get_setting("GN_VERSION"), dataset_name=request.args["dataset_name"]) @@ -165,7 +165,7 @@ def display_probeset_metadata(name: str): probeset=_d.get("probeset"), name=name, resource_id=request.args.get("resource-id"), - version=os.environ.get("GN_VERSION"), + version=get_setting("GN_VERSION"), dataset_name=request.args["dataset_name"] ) @@ -620,7 +620,7 @@ def show_history(dataset_id: str = "", name: str = ""): return render_template( "edit_history.html", diff=diff_data_, - version=os.environ.get("GN_VERSION"), + version=get_setting("GN_VERSION"), ) -- cgit v1.2.3