diff options
author | uditgulati | 2021-01-05 13:13:28 -0600 |
---|---|---|
committer | uditgulati | 2021-01-05 13:13:28 -0600 |
commit | 1e7a4d76fa36d1476fe37ae9b4c0a946fe99bce1 (patch) | |
tree | 0d18520e09fa0edce0080c773d0edd14750b855c /.github | |
parent | e106f5888cb4d761a6dcb71dc0273e461ef3c71a (diff) | |
parent | e36d40d64c1cf8476002c46b5c9dba308151f75c (diff) | |
download | genenetwork2-1e7a4d76fa36d1476fe37ae9b4c0a946fe99bce1.tar.gz |
Merge branch 'testing' of https://github.com/genenetwork/genenetwork2 into snp_browser_changes
Diffstat (limited to '.github')
-rw-r--r-- | .github/ISSUE_TEMPLATE/bug_report.md | 16 | ||||
-rw-r--r-- | .github/ISSUE_TEMPLATE/feature_request.md | 23 | ||||
-rw-r--r-- | .github/ISSUE_TEMPLATE/user_story.md | 8 | ||||
-rw-r--r-- | .github/PULL_REQUEST_TEMPLATE.md | 9 | ||||
-rw-r--r-- | .github/workflows/main.yml | 2 |
5 files changed, 37 insertions, 21 deletions
diff --git a/.github/ISSUE_TEMPLATE/bug_report.md b/.github/ISSUE_TEMPLATE/bug_report.md index 7d7e34a5..48bad39b 100644 --- a/.github/ISSUE_TEMPLATE/bug_report.md +++ b/.github/ISSUE_TEMPLATE/bug_report.md @@ -9,26 +9,26 @@ assignees: '' **Describe the bug** -A clear and concise description of what the bug is. +<!-- A clear and concise description of what the bug is. --> **To Reproduce** -Steps to reproduce the behavior +<!-- Steps to reproduce the behavior --> **Expected behavior** -A clear and concise description of what you expected to happen. +<!-- A clear and concise description of what you expected to happen. --> **Screenshots** -If applicable, add screenshots to help explain your problem. +<!-- If applicable, add screenshots to help explain your problem. --> **Environment setup (please complete the following information):** -- OS: [e.g. Linux] -- Guix Version (optional) -- [Anything else you think is relevant] +<!-- - OS: [e.g. Linux] --> +<!-- - Guix Version (optional) --> +<!-- - [Anything else you think is relevant] --> **Additional context** -Add any other context about the problem here. +<!-- Add any other context about the problem here. --> diff --git a/.github/ISSUE_TEMPLATE/feature_request.md b/.github/ISSUE_TEMPLATE/feature_request.md index 254754c6..eb6c3e4b 100644 --- a/.github/ISSUE_TEMPLATE/feature_request.md +++ b/.github/ISSUE_TEMPLATE/feature_request.md @@ -9,26 +9,33 @@ assignees: '' ## Is your feature request related to a problem? Please describe. -A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] +<!-- A clear and concise description of what the problem is. --> + +<!-- Example: I'm always frustrated when [...] --> ## Describe the solution you'd like -A clear and concise description of what you want to happen. +<!-- A clear and concise description of what you want to happen. --> ## Describe alternatives you've considered -A clear and concise description of any alternative solutions or features you've considered. +<!-- A clear and concise description of any alternative solutions or features you've considered. --> ## User Stories (optional) -As a _[role or persona]_, I want _[goal/ need]_ so that _[why]_ +<!-- Example: --> + +<!-- As a _[role or persona]_, I want _[goal/ need]_ so that _[why]_ --> + +<!-- **Feature:** _[Brief description of feature]_ --> -**Feature:** _[Brief description of feature]_ +<!-- _[Any additional descriptions on feature]_ --> -_[Any additional descriptions on feature]_ +<!-- **Scenario:** -**Scenario:** Please use _[Gherkin](https://cucumber.io/docs/gherkin/reference/)_ here +Please use _[Gherkin](https://cucumber.io/docs/gherkin/reference/)_ +here --> ## Additional context -Add any other context or screenshots about the feature request here. +<!-- Add any other context or screenshots about the feature request here. --> diff --git a/.github/ISSUE_TEMPLATE/user_story.md b/.github/ISSUE_TEMPLATE/user_story.md index 2682fc98..52ae775d 100644 --- a/.github/ISSUE_TEMPLATE/user_story.md +++ b/.github/ISSUE_TEMPLATE/user_story.md @@ -7,10 +7,10 @@ assignees: '' --- -As a _[role or persona]_, I want _[goal/ need]_ so that _[why]_ +<!-- As a _[role or persona]_, I want _[goal/ need]_ so that _[why]_ --> -**Feature:** _[Brief description of feature]_ +<!-- **Feature:** _[Brief description of feature]_ --> -_[Any additional descriptions on feature]_ +<!-- _[Any additional descriptions on feature]_ --> -**Scenario:** Please use _[Gherkin](https://cucumber.io/docs/gherkin/reference/)_ here +<!-- **Scenario:** Please use _[Gherkin](https://cucumber.io/docs/gherkin/reference/)_ here --> diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 223e24ef..f3371183 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,11 +1,20 @@ #### Description +<!--Brief description of the PR. What does this PR do? --> #### How should this be tested? +<!-- What should you do to test this PR? Is there any manual quality +assurance checks that should be done. What are the expectations --> #### Any background context you want to provide? +<!-- Anything the reviewer should be aware of ahead of testing --> + #### What are the relevant pivotal tracker stories? +<!-- Does this PR track anything anywhere? --> + #### Screenshots (if appropriate) #### Questions + +<!-- Are there any questions for the reviewer --> diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index f27feb5f..2342796a 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -11,7 +11,7 @@ on: jobs: unittest: runs-on: ubuntu-latest - container: bonfacekilz/python3-genenetwork2:latest + container: bonfacekilz/python3-genenetwork2:ad741c1 steps: # First start with mariadb set then checkout. The checkout gives |