Browse Source

daemon: Correctly handle EMLINK corner case when deduplicating.

Suggested by Caleb Ristvedt <caleb.ristvedt@cune.org>.

* nix/libstore/optimise-store.cc (LocalStore::optimisePath_): Save errno
from 'rename' before calling 'unlink'.
gn-latest-20200725
Ludovic Courtès 1 year ago
parent
commit
b930f0ba21
No known key found for this signature in database GPG Key ID: 90B11993D9AEBB5
  1. 3
      nix/libstore/optimise-store.cc

3
nix/libstore/optimise-store.cc

@ -215,9 +215,10 @@ void LocalStore::optimisePath_(OptimiseStats & stats, const Path & path, InodeHa
/* Atomically replace the old file with the new hard link. */
if (rename(tempLink.c_str(), path.c_str()) == -1) {
int renameErrno = errno;
if (unlink(tempLink.c_str()) == -1)
printMsg(lvlError, format("unable to unlink `%1%'") % tempLink);
if (errno == EMLINK) {
if (renameErrno == EMLINK) {
/* Some filesystems generate too many links on the rename,
rather than on the original link. (Probably it
temporarily increases the st_nlink field before

Loading…
Cancel
Save