Browse Source

packages: Optimize 'find-packages-by-name' to avoid disk accesses.

On a profile with 182 entries, "guix package --search-paths" goes from
4.5 seconds down to 0.4 second.

* gnu/packages.scm (find-packages-by-name): Make a name -> package vhash
  in a promise; access it with 'vhash-fold*'.
gn-latest-20200428
Ludovic Courtès 7 years ago
parent
commit
9ffc1c00e5
  1. 28
      gnu/packages.scm

28
gnu/packages.scm

@ -179,22 +179,20 @@ same package twice."
vlist-null
(all-package-modules))))
(define* (find-packages-by-name name #:optional version)
"Return the list of packages with the given NAME. If VERSION is not #f,
(define find-packages-by-name
(let ((packages (delay
(fold-packages (lambda (p r)
(vhash-cons (package-name p) p r))
vlist-null))))
(lambda* (name #:optional version)
"Return the list of packages with the given NAME. If VERSION is not #f,
then only return packages whose version is equal to VERSION."
(define right-package?
(if version
(lambda (p)
(and (string=? (package-name p) name)
(string=? (package-version p) version)))
(lambda (p)
(string=? (package-name p) name))))
(fold-packages (lambda (package result)
(if (right-package? package)
(cons package result)
result))
'()))
(let ((matching (vhash-fold* cons '() name (force packages))))
(if version
(filter (lambda (package)
(string=? (package-version package) version))
matching)
matching)))))
(define find-newest-available-packages
(memoize

Loading…
Cancel
Save