Browse Source

pull: Don't use rename(2) across potentially different devices.

Reported by Formbi on #guix.

* guix/scripts/pull.scm (migrate-generations): Use 'symlink' and
'delete-file' instead of 'rename-file'.  The latter could lead to EXDEV
when $HOME and /var were different partitions.
gn-latest-20200428
Ludovic Courtès 3 years ago
parent
commit
8036b0942b
No known key found for this signature in database GPG Key ID: 90B11993D9AEBB5
  1. 7
      guix/scripts/pull.scm

7
guix/scripts/pull.scm

@ -239,7 +239,7 @@ Download and deploy the latest version of Guix.\n"))
(string-append (config-directory #:ensure? #f) "/current"))
(define (migrate-generations profile directory)
"Migration the generations of PROFILE to DIRECTORY."
"Migrate the generations of PROFILE to DIRECTORY."
(format (current-error-port)
(G_ "Migrating profile generations to '~a'...~%")
%profile-directory)
@ -251,7 +251,10 @@ Download and deploy the latest version of Guix.\n"))
(target (string-append directory "/current-guix-"
(number->string generation)
"-link")))
(rename-file source target)))
;; Note: Don't use 'rename-file' as SOURCE and TARGET might
;; live on different file systems.
(symlink (readlink source) target)
(delete-file source)))
(profile-generations profile))
(symlink current (string-append directory "/current-guix"))))

Loading…
Cancel
Save